Don't report journal name as abbreviated when full name = abbreviated name#4116
Conversation
…abbreviated name
stefan-kolb
left a comment
There was a problem hiding this comment.
I was thinking about this yesterday, too.
Your solution is fine, although it changes the logic of the abbreviation repository in a way that in not 100% intuitive.
What do you think about handling those false positives in the checker instead, so the repository logic stays pure, i.e.:
In the checker,
- check if abbreviation is found
- if abbreviation == long form no warning
- else warning
|
Thanks for the feedback. Your solution was my initial idea but then went on to modify the In the end it's almost a question of taste and I'm also fine changing it to your solution (if you think the additional work is worth it ;-) ). |
|
That was exactly my thought too (that Bioinformatics is no abbreviation of bioinformatics), but then we should rather cleanup the list than the code?! But then I thought, ok they want to have this journal in there... |
* upstream/master: (22 commits) fix failing architecture test by making test class public again migrate architecture test to junit jupiter Fix build... (#4128) fix checkstyle after merge Migrate Review field in entry preview to comment (#4100) [WIP] Split push to applications in logic and gui (#4110) Fix checkstyle Fix #4115: Don't report journal name as abbreviated when full name = abbreviated name (#4116) Use <kbd>in changelog Groups right click (#4061) Fix open thread prevents shutdown (#4111) Extract v4.x changelog (#4125) Saves and reloads window state on close and on open (#4124) Fix convert to bibtex moves contents of the file field (#4123) Opens the directory of the currently edited file when opening a new file (#4106) Don't run on Swing thread Properly shutdown telemetry client Code cleanup Remove Swing stuff (L&F, font customization) Properly shutdown JabRef (not with System.exit) Replace swing clipboard with JavaFX one ... # Conflicts: # src/main/java/org/jabref/gui/BasePanel.java # src/main/java/org/jabref/gui/JabRefFrame.java # src/main/java/org/jabref/gui/maintable/MainTable.java # src/main/java/org/jabref/gui/search/SearchResultFrame.java # src/main/java/org/jabref/preferences/JabRefPreferences.java
Fixes #4115.