Fix that sometimes an empty side pane is shown#4105
Merged
Conversation
tobiasdiez
commented
Jun 5, 2018
Member
- Change in CHANGELOG.md described
- Tests created for changes
- Manually tested changed features in running JabRef
- Screenshots added in PR description (for bigger UI changes)
- Ensured that the git commit message is a good one
- Check documentation status (Issue created for outdated help page at help.jabref.org?)
Siedlerchr
approved these changes
Jun 6, 2018
Siedlerchr
added a commit
that referenced
this pull request
Jun 6, 2018
* upstream/master: (89 commits) Fix that sometimes an empty side pane is shown (#4105) Update gradle from 4.7 to 4.8 (#4102) Add gradle task downloadDependencies and use it at CircleCI (#4091) Set minimum java to 171 (#4095) Also use https in the CHANGELOG itself Add missing CHANGELOG entry Fix localiazation test Use official TempFolder extension for JUnit 5 tests Remove menu* from crowdin.yml (#4094) Merge recent changes to exporter/importer Add missing CHANGELOG entry New translations JabRef_en.properties (Vietnamese) New translations JabRef_en.properties (Dutch) New translations JabRef_en.properties (French) New translations JabRef_en.properties (German) New translations JabRef_en.properties (Greek) New translations JabRef_en.properties (Indonesian) New translations JabRef_en.properties (Italian) New translations JabRef_en.properties (Japanese) New translations JabRef_en.properties (Danish) ... # Conflicts: # src/main/java/org/jabref/gui/shared/ConnectToSharedDatabaseDialog.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.