Use JavaFX-native SVGPath for logo in About dialog#4035
Merged
Conversation
(cherry picked from commit 6608b2b)
6 tasks
Siedlerchr
approved these changes
May 15, 2018
Siedlerchr
approved these changes
May 15, 2018
Siedlerchr
added a commit
that referenced
this pull request
May 22, 2018
* upstream/maintable-beta: (46 commits) update gradle to 4.7 (#4049) Add missing translation for "HTML to Unicode" (#4046) New Crowdin translations (#4042) Use all-text-fields magic also in BibTeX cleanup. (#4039) Switch to org.postgresql (#4031) Fix freeze when importing (#4037) Use JavaFX-native SVGPath for logo in About dialog (#4035) Remove reflection hack to set WM_CLASS (#4034) Fix initial freeze when downloading files Inline comment Move color related method Extract dialog service to field Extract dialog service to field Remove unused class Show tooltip for icon-based columns Remove commented-out code Convert static methods to instance members (and fix spelling) Fix formatting Fix formatting Remove unused argument ... # Conflicts: # build.gradle # gradle/wrapper/gradle-wrapper.properties # src/main/java/org/jabref/gui/GUIGlobals.java # src/main/java/org/jabref/gui/SidePaneComponent.java # src/main/java/org/jabref/gui/groups/GroupModeViewModel.java # src/main/java/org/jabref/gui/groups/GroupSidePane.java # src/main/java/org/jabref/gui/help/AboutDialogView.java # src/main/java/org/jabref/gui/openoffice/OpenOfficePanel.java # src/main/java/org/jabref/logic/shared/PostgreSQLProcessor.java # src/main/resources/l10n/JabRef_en.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of requiring an additional library for rendering one SVG image, the JavaFX-native SVGPath should be used.
Removing the dependency
de.codecentric.centerdevice:javafxsvg:1.3.0also removed the transitive dependency on Apache Commons IO, so its usages had to be removed.This is part of #3421