Skip to content

Shortittle bibtexkeypattern now also discards small words#4030

Merged
Siedlerchr merged 2 commits into
masterfrom
shorttitlewithoutsmallwords
May 12, 2018
Merged

Shortittle bibtexkeypattern now also discards small words#4030
Siedlerchr merged 2 commits into
masterfrom
shorttitlewithoutsmallwords

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented May 11, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Feature Request in the forum:
http://discourse.jabref.org/t/jabref-differences-in-shorttitle-between-versions-3-8-1-and-4-not-discounting-the-a-an-of-in-titles/1147

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@Siedlerchr Siedlerchr requested a review from koppor May 11, 2018 18:42
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 11, 2018
Siedlerchr added a commit to JabRef/user-documentation that referenced this pull request May 11, 2018
@Siedlerchr
Update Description of shorttitle and function words
b464693 
Refs JabRef/jabref#4030
@Siedlerchr Siedlerchr mentioned this pull request May 11, 2018
Merged
1 task
@Siedlerchr

Siedlerchr commented May 12, 2018

Copy link
Copy Markdown
Member Author

As I have tested this and already prepared an update to the help page I am going to merge this now.

@Siedlerchr Siedlerchr merged commit 899d267 into master May 12, 2018
@Siedlerchr Siedlerchr deleted the shorttitlewithoutsmallwords branch May 12, 2018 21:46
Siedlerchr added a commit that referenced this pull request May 22, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into maintable-beta
8cbe028 
* upstream/master:
  update gradle to 4.7 (#4049)
  Add missing translation for "HTML to Unicode" (#4046)
  New Crowdin translations (#4042)
  Use all-text-fields magic also in BibTeX cleanup. (#4039)
  Shortittle bibtexkeypattern now also discards small words (#4030)
Siedlerchr added a commit that referenced this pull request May 25, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/maintable-beta' into sharedblogin
b39455a 
* upstream/maintable-beta:
  update gradle to 4.7 (#4049)
  Add missing translation for "HTML to Unicode" (#4046)
  New Crowdin translations (#4042)
  Use all-text-fields magic also in BibTeX cleanup. (#4039)
  Shortittle bibtexkeypattern now also discards small words (#4030)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@koppor koppor Awaiting requested review from koppor

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Siedlerchr @tobiasdiez