Skip to content

Add date checker#4007

Merged
tobiasdiez merged 7 commits into
masterfrom
dateValidity
May 26, 2018
Merged

Add date checker#4007
tobiasdiez merged 7 commits into
masterfrom
dateValidity

Conversation

@tobiasdiez

Copy link
Copy Markdown
Member

... that warns about invalid dates in the date and urldate field.


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 3, 2018
@Siedlerchr

Copy link
Copy Markdown
Member

You could add eventdate which is biblatex field with entry type proceedings

@stefan-kolb

Copy link
Copy Markdown
Member

I would love to see a few more test for possible date values!

@mlep

mlep commented May 15, 2018

Copy link
Copy Markdown
Contributor

In biblatex, there is also the field origdate.

@tobiasdiez

Copy link
Copy Markdown
Member Author

Thanks for the feedback!

@tobiasdiez tobiasdiez merged commit 787902c into master May 26, 2018
@tobiasdiez tobiasdiez deleted the dateValidity branch May 26, 2018 18:29
Siedlerchr added a commit that referenced this pull request May 27, 2018
…leType

* upstream/master: (33 commits)
  Import inspection uses now same font size setttings as maintable (#4062)
  Add date checker (#4007)
  Enable tests
  macOs push to application fix
  Fix #4041 to make Push to Application work again on OSX. (#4057)
  Add NormalizeEnDashesFormatter (#4045)
  Package private for tests
  Shutdown duplicate code
  Move migrations to PreferencesMigrations
  Structure startup
  Extract migrations
  A first solution for the cli problem #4038 (#4047)
  New translations JabRef_en.properties (French) (#4052)
  Update CHANGELOG.md
  Fix checkstyle
  Make test more informative in the failing case
  New translations JabRef_en.properties (French) (#4051)
  New translations JabRef_en.properties (Vietnamese) (#4050)
  Make Formatter an abstract class (and remove AbstractFormatter)
  New Crowdin translations (#4048)
  ...

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants