Change representation of encodings to Charset#396
Merged
Conversation
Contributor
|
I do like this. Can there be any issues if a previous file has an encoding format that is not understood and is loaded with a newer version of jabref? |
2 tasks
Member
Author
|
As far as I can see there is no problem. The encoding from the file is given to |
Contributor
|
Ok. Please rebase, I will merge it in. |
Instead of representing an encoding as a string we now use a Charset. This idea was already discussed in PR JabRef#370.
Member
Author
|
Rebased. |
simonharrer
added a commit
that referenced
this pull request
Nov 30, 2015
Change representation of encodings to Charset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of representing an encoding as a string we now use a Charset.
This idea was already discussed in PR #370.