Integrate CodeStyleTest into StringUtilTest#3907
Merged
Merged
Conversation
stefan-kolb
approved these changes
Mar 31, 2018
Member
|
Can be removed after refactoring Stringutils anyway. Also, as we have a Guava dependency now, maybe we can replace a lot of our helper functions? |
Member
Author
|
We checked this approx half a year ago and none of these functions were present in Guava. They are IMHO mostly available in Apache Commons Lang, but our "spirit" wants to remove this well-established library to the more modern Guava library (https://github.com/google/guava/wiki/StringsExplained). |
Member
|
Well then you can move it anyway. |
lenhard
approved these changes
Apr 1, 2018
lenhard
left a comment
Member
There was a problem hiding this comment.
Moving the code is fine, imho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During #3704, I observed that having many classes causes difficulties in migrating to a multi module build. Since 1) we have ArchUnit in place and 2) the current test in "CodeStyleTest" just covers
StringUtils. Therefore, I propose to include the test included there intoStringUtilTest.