[WIP] Multi module build by koppor · Pull Request #3704 · JabRef/jabref

koppor · 2018-02-07T02:51:49Z

This is a huge step towards #110 and prepares #3421 somehow.

This enables gradle multi module build.

The dependencies of "logic" were not as clean as I thought. I removed dependencies to GUI or moved packages back to gui (shared, remote).

We should get this in ASAP.

Open issues:

src/main/gen should be removed from version control - generated code like jabref.gui/src/main/gen/org/jabref/logic/importer/fileformat/mods/RoleTermDefinition.java is put under version control; is this desired?
inherit more from root project avoid duplication of plugins dependencies and tasks (https://docs.gradle.org/current/userguide/multi_project_builds.html)
GUI does not start: Cannot load file GroupTree.fxml
Install4J does not find the generated JARs.
The OO preferences should be fixed (reading/writing not fully supported yet). All other features should work. - done in Prepare multi module build #3913
jar are not uploaded to CircleCI - are they stored somewhere else? http://builds.jabref.org/multi-module-build/
Tests not executed on travis. :org.jabref.gui:junitPlatformTest - this works locally though.
Tests fail on travis. E.g., [main] ERROR org.jabref.logic.l10n.Localization - Messages are not initialized before accessing All entries

- FreeCite does not generate a non-used BibtexKeyGenerator anymore - Introduce ExporterFactoryFactory - Introduce SavePreferenceFactory

…p in gui

tobiasdiez · 2018-02-07T09:30:04Z

The fxml and css files should lie in the same folder as the view GroupTreeView

tobiasdiez · 2018-02-07T09:33:05Z

+
+import java.nio.charset.Charset;
+
+public class SavePreferencesFactory {


You can just move these methods to JabRefPreferences.

# Conflicts: # build.gradle

…dules

# Conflicts: # org.jabref.gui/src/test/java/org/jabref/SearchQueryHighlightListenerTest.java # org.jabref.gui/src/test/java/org/jabref/gui/importer/EntryFromFileCreatorManagerTest.java # org.jabref.gui/src/test/java/org/jabref/gui/importer/EntryFromPDFCreatorTest.java # org.jabref.gui/src/test/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java # org.jabref.logic/src/test/java/org/jabref/logic/xmp/XMPSchemaBibtexTest.java # org.jabref.model/src/test/java/org/jabref/model/strings/StringUtilTest.java # src/jmh/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java # src/test/java/org/jabref/CodeStyleTests.java # src/test/java/org/jabref/logic/importer/DatabaseFileLookupTest.java # src/test/java/org/jabref/preferences/LastFocusedTabPreferencesTest.java

…abled

…abled

koppor · 2018-02-14T20:27:32Z

Solved via 9bfea57

Current state: Compiles fine on Windows, but on Linux:

FAILURE: Build failed with an exception.

* Where:
Build file '/home/ubuntu/jabref/org.jabref.logic/build.gradle' line: 73

* What went wrong:
Execution failed for task ':org.jabref.logic:processResources'.
> No signature of method: static org.gradle.api.Project.getRootProject() is applicable for argument types: () values: []

Reproducible via

docker run -it --rm --name my-maven-project -v "d:/git-repositories/jabref/jabref:/usr/src/mymaven" -w /usr/src/mymaven jabref/javafx ./gradlew release

tobiasdiez · 2018-02-14T22:30:36Z

@@ -1,5 +1,6 @@
 # no generated files in version control
-src/main/gen/
+**/src/main/gen/


generated code like jabref.gui/src/main/gen/org/jabref/logic/importer/fileformat/mods/RoleTermDefinition.java is put under version control; is this desired?

That should not happen. We have to remove that code.

I will double check.

# Conflicts: # org.jabref.gui/src/main/java/org/jabref/JabRefMain.java

koppor · 2018-02-18T13:42:03Z

This will be frozen until #3733 is merged. Reason: That PR also does huge refactorings.

koppor · 2018-03-31T10:52:05Z

I close this PR as this is unfinished.

I created #3913 as follow up. The small changes are filed as PRs #3907, #3908, #3909, #3910, #3911, #3912

The only thing not followed-up is the gradle multi-module-build (Co-Authored-By @stefan-kolb). I propose to leave it to @florian-beetz to investigate the gradle scripts and see whether they help him to get JabRef ready for Java9.

koppor added 14 commits February 7, 2018 00:10

Initial gradle build files

fc626a6

Result of linter

a0b1397

Fix linter

83b74c8

Create org.jabref.logic package (besides logic.shared and logic.remote)

86714e9

Ignoure out directory

f23e579

Three more classes for logic

ae1102b

Seperate logic from GUI

fd3ffa2

- FreeCite does not generate a non-used BibtexKeyGenerator anymore - Introduce ExporterFactoryFactory - Introduce SavePreferenceFactory

Refactor OpenOffice preferences

fa1536f

autosave and backup read config from preferences at each event -> kee…

68335c9

…p in gui

Refactor CleanupPreset

1ee315a

Make ModsImporter independent from JabRefPreferences

4b7ea7d

FileAnnotationCache needs fileDirectoryPreferences

2ba26da

Some compile fixes

7dfe2ed

lint build.gradle

b889fed

koppor added the jabcon label Feb 7, 2018

koppor changed the title ~~Multi module build~~ [WIP] Multi module build Feb 7, 2018

tobiasdiez reviewed Feb 7, 2018

View reviewed changes

Fix install4j location

df4ef0d

koppor force-pushed the multi-module-build branch from 732300e to df4ef0d Compare February 7, 2018 09:33

koppor added 10 commits February 7, 2018 11:17

Merge remote-tracking branch 'origin/master' into multi-module-build

2f52b51

# Conflicts: # build.gradle

Move jabref.install4j to right folder

a46d569

Move model tests from gui to model/logic

9646887

Duplicate TreeNodeTestData, because test data is not shared across mo…

76c1d29

…dules

lint build.gradle files

8903b26

Move logic tests from org.jabref.gui org.jabref.logic

2f2e81e

Fix bibtexTestData location

4afbb8b

Remove GenerateCharacterTable - it was never published officially

9b5e1f8

Create org.jabref.cli.xmp project

4fec000

Fix location of test resources

abbe777

koppor force-pushed the multi-module-build branch from 8a91c8b to 0c96e14 Compare February 8, 2018 14:55

koppor added 3 commits February 8, 2018 16:15

Fix iconpath (again)

ca05215

Fix artifacts path

13b85df

Better 9 binaries than nothing

ff6f440

Siedlerchr mentioned this pull request Feb 11, 2018

migrate majority of tests to junit5 #3711

Merged

5 tasks

koppor added 7 commits February 14, 2018 16:14

Fix file paths

9145feb

Compile fix and migrate OAI2HandlerFetcherTest @ignore to JUnit5 @dis…

265507d

…abled

Fix Install4J build

7c8b761

Fix build on CircleCI

2985d71

Merge remote-tracking branch 'origin/master' into multi-module-build

17e9969

No daemon at CircleCI

92cf1a3

koppor added 3 commits February 14, 2018 21:38

Initial compilation also is a development build

de4a574

Replace Project.getRootProject() by rootProject

9bfea57

Fix test

a1deb36

tobiasdiez reviewed Feb 14, 2018

View reviewed changes

Merge branch 'master' into multi-module-build

8029a3f

# Conflicts: # org.jabref.gui/src/main/java/org/jabref/JabRefMain.java

johannes-manner mentioned this pull request Feb 20, 2018

Refactor dublin core utility #3756

Merged

5 tasks

This was referenced Mar 31, 2018

Integrate CodeStyleTest into StringUtilTest #3907

Merged

Add required mock to LinkedfileViewModelTest #3909

Merged

Prepare multi module build #3913

Merged

koppor closed this Mar 31, 2018

koppor removed the jabcon label Mar 31, 2018

florian-beetz mentioned this pull request Jun 20, 2018

[WIP] First attempt for JDK11 compilation - #Java11 #3421

Merged

6 tasks

florian-beetz mentioned this pull request Jul 23, 2018

[WIP] Modularize JabRef with JPMS #4230

Closed

8 tasks

stefan-kolb deleted the multi-module-build branch August 23, 2019 20:25

koppor mentioned this pull request Jun 7, 2021

[WIP] Jabrefonline apollo #7798

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] Multi module build#3704

[WIP] Multi module build#3704
koppor wants to merge 90 commits into
masterfrom
multi-module-build

koppor commented Feb 7, 2018 •

edited

Loading

Uh oh!

tobiasdiez commented Feb 7, 2018

Uh oh!

tobiasdiez Feb 7, 2018

Uh oh!

koppor commented Feb 14, 2018 •

edited

Loading

Uh oh!

tobiasdiez Feb 14, 2018

Uh oh!

koppor Feb 15, 2018

Uh oh!

koppor commented Feb 18, 2018

Uh oh!

koppor commented Mar 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		import java.nio.charset.Charset;

		public class SavePreferencesFactory {

Uh oh!

Conversation

koppor commented Feb 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasdiez commented Feb 7, 2018

Uh oh!

tobiasdiez Feb 7, 2018

Choose a reason for hiding this comment

Uh oh!

koppor commented Feb 14, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasdiez Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

koppor Feb 15, 2018

Choose a reason for hiding this comment

Uh oh!

koppor commented Feb 18, 2018

Uh oh!

koppor commented Mar 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

koppor commented Feb 7, 2018 •

edited

Loading

koppor commented Feb 14, 2018 •

edited

Loading