Update Eclipse style to intellij style#3827
Conversation
Exported from Oxygen.2
koppor
left a comment
There was a problem hiding this comment.
Cannot judge the Eclipse changes, but you are the eclipse user/export, so you should know best.
|
|
||
| # Eclipse: | ||
|
|
||
| In case the Eclipse style needs to be adjusted for the eclipse.gradle file: |
There was a problem hiding this comment.
I don't understand that. Maybe, the gradle script needs to be rewritten to inject an exported XML file`?
There was a problem hiding this comment.
I think I just found a simpler way. I will update the doc accordingly
There was a problem hiding this comment.
I generally found a nice and simple way. One can directly export the file in eclipse as EPF file in properties format
The main drawback is that it's not possible to import it with gradle (argh!).
So therefore the only solution would be to read the file, remove all unnecessary lines and write that into the .prefs file (ideally once). Then we can just copy over the prefs file to the workspace.
tobiasdiez
left a comment
There was a problem hiding this comment.
I also cannot test these changes, but trust you in this.
| @@ -0,0 +1,328 @@ | |||
| #Fri Mar 09 22:05:27 CET 2018 | |||
There was a problem hiding this comment.
Yes, as a reference file. And this file can still be imported manually.
Mabye someone more experienced in gradle/scripting can create a simple script to copy the things from that file to the workspace org.eclipse.jdt.ui.prefs file
|
Gradle uses Groovy, which is similar to Java. You can use the normal Java
classes there. Appending with Java shouldn't be that hard, is it? 😇
Am 10.03.2018 15:25 schrieb "Christoph" <notifications@github.com>:
… ***@***.**** commented on this pull request.
------------------------------
In config/Eclipse Code Style.epf
<#3827 (comment)>:
> @@ -0,0 +1,328 @@
+#Fri Mar 09 22:05:27 CET 2018
Yes, as a reference file. And this file can still be imported manually.
Mabye someone more experienced in gradle/scripting can create a simple
script to copy the things from that file to the workspace
org.eclipse.jdt.ui.prefs file
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3827 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABTafnxUchrgoRdb1CEIxkah0jpKxJR7ks5tc-J2gaJpZM4SkotL>
.
|
|
I merge this for the moment. As we don't change our code style that often we can postpone the automatic creation of the prefs |
…drop * upstream/maintable-beta: (97 commits) Update Eclipse style to intellij style (#3827) fix some not on fx thread dialogs in preferences fix inital save error Convert last dialog to javafx refactor exception Merge changes for renamed actions New Crowdin translations (#3835) Partial revert of #3715 since double click on group should expand/collapse it (#3834) Add Spanish translations (#3833) update applicationsinsights update javafxsvg to 1.3.0 Disable FTP Download on CI Apply copy linked files dialog fix from master Show dialog when copy files did not found file (#3826) Remove customjfx (#3779) Disable FTP Download on CI Remove color customization for maintable from preferences (#3808) Remove erroneous escape character (#3831) New translations JabRef_en.properties (French) New translations JabRef_en.properties (Tagalog) New translations JabRef_en.properties (Italian) New translations JabRef_en.properties (Indonesian) ... # Conflicts: # src/main/java/org/jabref/gui/maintable/MainTable.java
…esDlg * upstream/maintable-beta: (346 commits) add missing localization fix keybinding of entry editor add missing keybinding of search Update java-string-similarity from 1.0.1 -> 1.1.0 Update log4j from 2.10.0 -> 2.11.0 Update guava from 24.0 -> 24.1 New Crowdin translations (#3853) Fetcher refactorings Fix ScienceDirect fetcher #3854 Fix Google Scholar fetcher test Fix DBLP fetcher tests Move migration to top level package New Crowdin translations (#3851) Update Eclipse style to intellij style (#3827) fix some not on fx thread dialogs in preferences fix inital save error Convert last dialog to javafx refactor exception Update mysql-connector from 5.1.45 -> 5.1.46 Update mockito-core from 2.15.0 -> 2.16.0 New translations JabRef_en.properties (Spanish) New translations Menu_en.properties (Spanish) Merge changes for renamed actions ...
Fixes #3815
Screenshots of indentation in #3815
(cherry pick to master afterwards)