Save order of columns across sessions#3783
Conversation
|
|
||
| /*** end: special fields ***/ | ||
|
|
||
| static class TableRow { |
There was a problem hiding this comment.
Any reason why this has to be static?
There was a problem hiding this comment.
No idea... (the code quality in the preferences tabs is so bad anyway).
There was a problem hiding this comment.
I personally see to reason to have this whole column stuff in the preferences tab anylonger. I think it was only added because we could not save the column reordering the user did directly on the maintable. I would vote to remove that stuff completely.
There was a problem hiding this comment.
Well, currently, this is the only place where you can choose which columns are shown.
There was a problem hiding this comment.
Why not adding a table column selector like it's possible in nearly every table
There was a problem hiding this comment.
Here is an example https://gist.github.com/Roland09/d92829cdf5e5fee6fee9
There was a problem hiding this comment.
This is a good idea! I have to think a bit more about it and how to make it work for JabRef (we allow also columns of the form author/editor and have to many fields to display them all in a drop down - possible a combination of drop down and text field may work). But not as part of this PR.
|
Can I still change the order and width in the settings? |
|
@Siedlerchr Yes, this should still work. |
After the user reorder the columns of the maintable per drag and drop, these changes are now saved in the preferences. Moreover, I refactored a bit how preferences are loaded from the global preferences class.