[WIP] Django style unchained.#3655
Conversation
Siedlerchr
left a comment
There was a problem hiding this comment.
Good! Now we just need the same for the Eclipse style.
|
Code examples may be better than words, but only if they are really really obvious ;-) To be honest, I don't get why the new style is strictly better. I have nothing against it, but I also don't see any obvious benefit. To me, it just doesn't matter. Could you convince me with words? |
|
Well, there are of course no real benefits. We will not perform 200% more efficient because of this change. It's just a matter of taste and for me fluent code (with builders or the stream api) does not look "nice". But of course this is a subjective opinion. For example, why is return field.getValues().stream()
.map(SpecialFieldValueViewModel::new)
.collect(Collectors.toList());The reformatted return field.getValues().stream()
.map(SpecialFieldValueViewModel::new)
.collect(Collectors.toList());is easier to read and to "parse" in my opinion. Get values, map them, collect. Finish. |
|
Ok, I am buying into that :-) Could we do the same configuration for Eclipse here as well (as requested by @Siedlerchr ). Just to ensure that there is no constant reformatting of the code with different IDEs. |
|
https://stackoverflow.com/questions/6275785/wrapping-chained-method-calls-on-a-separate-line-in-eclipse-for-java |
* 'master' of github.com:JabRef/jabref: Allow spaces in DOIs Remove irrelevant log messages during XMP reading Adapt log4j configuration for cleaner junit tests #3511 Eclipse Django style #3655 Better code style for chained methods Update build.gradle Update build.gradle cleanup and refactoring in DuplicateCheck class code review fixes - consider pages of the same book separately in duplications detection process; add more tests differentiate inbooks with the same author and title, but different chapter Remove deprecated static BibtexParser.parse method Use stream in matcher (#3696) Add some BibtexNameFomatter comments Add exception for Jacoco Set jacoco toolVersion earlier set jacoco version globally
* upstream/master: (47 commits) Fix Google Scholar fetcher Use english for all LCID mappings #1851 remove import preferences test mock import and convert to junit5 fix #3693 (#3702) Fix space leads to jump in entry editor (#3699) Fix #3669 Extract creation of the contents of FileAnnotationTabController Fix changelog Fix NPE Remove unnecessary file use processbuilder for calling external apps Fix color highlight of odd linked files Fixes #2964 Fix koppor issues #3 Allow spaces in DOIs Remove irrelevant log messages during XMP reading Adapt log4j configuration for cleaner junit tests #3511 Eclipse Django style #3655 Better code style for chained methods Update build.gradle ...
Code examples are better than words. So, let them speak. Instead of the current
we now get the nicely aligned