Library properties: no change but.. (issue #3562)#3579
Merged
Conversation
Siedlerchr
reviewed
Dec 25, 2017
| return changed; | ||
| } | ||
|
|
||
| private boolean newAndOldOrderCinfigIsSame(SaveOrderConfig newSaveOrderConfig, SaveOrderConfig oldSaveOrderConfig) { |
Member
There was a problem hiding this comment.
looks like a typo here -> cinfig -> Config
Siedlerchr
approved these changes
Dec 25, 2017
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
I tested your changes locally and it works.
Member
|
@JabRef/developers A second review needs to be done |
tobiasdiez
requested changes
Dec 29, 2017
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
Just a very minor remark and then we can merge this.
| } | ||
|
|
||
| private boolean newAndOldOrderConfigIsSame(SaveOrderConfig newSaveOrderConfig, SaveOrderConfig oldSaveOrderConfig) { | ||
| return newSaveOrderConfig.equals(oldSaveOrderConfig) ? false : true; |
Member
There was a problem hiding this comment.
This is equivalent to !newSaveOrderConfig.equals(oldSaveOrderConfig), right? In this case you can also directly inline this code.
Member
|
@PJozeph Thanks for the quick follow-up and a Happy New Year! |
Siedlerchr
added a commit
that referenced
this pull request
Jan 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user wanted to lead default Library properties, after clicking OK button even though there was no modification in Library property the bibTeX tab marked as modified. I fixed this bug so no need to worry about this anymore.
Fixes #3562
gradle localizationUpdate?