Added checking integrity dialog#3388
Merged
Merged
Conversation
Siedlerchr
requested changes
Nov 1, 2017
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution! Just some minor changes and it looks good
| import javax.swing.JDialog; | ||
| import javax.swing.JOptionPane; | ||
| import javax.swing.JPopupMenu; | ||
| import javax.swing.JProgressBar; |
Member
There was a problem hiding this comment.
You somehwere have a checkstyle error here:
checkstyleMain[ant:checkstyle] [ERROR] /home/travis/build/JabRef/jabref/src/main/java/org/jabref/gui/actions/IntegrityCheckAction.java:8: 'javax.swing.Action' should be separated from previous imports. [ImportOrder]
FAILED
Member
There was a problem hiding this comment.
If you use Eclipse, exeute ./gradlew eclipse and it will import the correct settings for the checkstyle.
| JProgressBar integrityProgressBar = new JProgressBar(); | ||
| integrityProgressBar.setIndeterminate(true); | ||
| integrityProgressBar.setStringPainted(true); | ||
| integrityProgressBar.setString("Checking integrity..."); |
Member
There was a problem hiding this comment.
Please use a Localized message and add it to the l10n files
https://github.com/JabRef/jabref/wiki/Code-Howtos#using-localization-correctly
Contributor
Author
|
Thanks for fast response. I fixed the problems. |
Member
|
Thanks for your contribution! I tested the changes locally and it works fine! Feel free to look at other issues as well! |
Siedlerchr
added a commit
that referenced
this pull request
Nov 3, 2017
* upstream/master: (22 commits) Improve SyncLang.py (#3184) Config intellj code style to adhere to empty lines checkstyle rule (#3365) Don't list same look and feels more than once (#3393) progessdialog and result table are now shown correclty on copy files Export pdf/linked files (#3147) Added checking integrity dialog (#3388) Update richtext and flowless (#3386) Source tab: hide notification pane when code is correct again (#3387) Titles are optional at crossref (#3378) Update entry for every change in the source panel (#3366) Rework AutoSetFileLinks (#3368) revert wrongly commited changes Refactorings (#3370) Fix freezing when running cleanup file operations like rename (#3315) This additional style setting for IDEA (#3355) Fix checkstyle Add proper equals to content selector Delete unused code Extract difference finder from gui to logic Remove unnecessary EntrySorter ... # Conflicts: # src/main/java/org/jabref/gui/entryeditor/SourceTab.java
Siedlerchr
added a commit
that referenced
this pull request
Nov 4, 2017
* upstream/master: (26 commits) Fix static localized text (#3400) Fix problems in source editor (#3398) Fix MathSciNet fetcher (#3402) Fix NPE when saving new file Improve SyncLang.py (#3184) Config intellj code style to adhere to empty lines checkstyle rule (#3365) Don't list same look and feels more than once (#3393) progessdialog and result table are now shown correclty on copy files Export pdf/linked files (#3147) Added checking integrity dialog (#3388) Update richtext and flowless (#3386) Source tab: hide notification pane when code is correct again (#3387) Titles are optional at crossref (#3378) Update entry for every change in the source panel (#3366) Rework AutoSetFileLinks (#3368) revert wrongly commited changes Refactorings (#3370) Fix freezing when running cleanup file operations like rename (#3315) This additional style setting for IDEA (#3355) Fix checkstyle ... # Conflicts: # CHANGELOG.md
Siedlerchr
added a commit
that referenced
this pull request
Nov 19, 2017
* upstream/master: Improve SyncLang.py (#3184) Config intellj code style to adhere to empty lines checkstyle rule (#3365) Don't list same look and feels more than once (#3393) progessdialog and result table are now shown correclty on copy files Export pdf/linked files (#3147) Added checking integrity dialog (#3388)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is related to #3358. JabRef looked like it is hanging during long integrity checks. I added a dialog with a progress bar to show that it is working.
gradle localizationUpdate?