Terminate JavaFX thread when running with "nogui" option#3274
Merged
Conversation
Siedlerchr
approved these changes
Oct 7, 2017
Member
|
Thanks for your contribution, would you be so kind to add a changelog entry? |
tobiasdiez
approved these changes
Oct 7, 2017
lenhard
approved these changes
Oct 7, 2017
lenhard
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution. All that's needed is a changelog entry and then this is good to go,
Contributor
Author
|
Sorry for omitting the changelog entry -- I wasn't sure if such fix qualified for a mention there. Will add it in a moment. |
Member
|
@MrTosz Thanks! The rule is simple: If it didn't work/has not been present in the version before, than we add a changelog entry. We are looking forward to more contributions from you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #3247
When JabRef was run with the '-n' parameter, i.e. the "No GUI" option, like:
java -jar JabRef.jar -nor any other reason for
ArgumentProcessor#shouldShutDown()returningtruetook place, the application should shut down after performing custom export filters etc. However,Platform.exit()wasn't called, so the JavaFX thread kept running indefinitely. Simply added this call to resolve the problem.