Minimize depdencies fetched by using net.corda:jfx#3017
Merged
Conversation
6 tasks
Siedlerchr
approved these changes
Jul 15, 2017
Siedlerchr
left a comment
Member
There was a problem hiding this comment.
Looks like a workaround, I think we just should convert the list class
Member
|
The conversion would be the more desirable solution. But if we don't get the conversion done before the release of 4.0, we might consider to merge it anyway. I'd say: Let's keep this PR open until either someone does the conversion or we want to release 4.0. |
Member
Author
|
I assigned #3014 to a milestone, so we are reminded that there is some work left. I will merge this in as it will surely reduce the size of our JAR. |
Siedlerchr
added a commit
that referenced
this pull request
Jul 16, 2017
* upstream/master: Minimize depdencies fetched by using net.corda:jfx (#3017)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to reduce the mass of transitive dependencies fetched by using corda.net. See #3014.
gradle localizationUpdate?