Skip to content

Reimplement content selectors#3003

Merged
tobiasdiez merged 4 commits into
masterfrom
reimplementContentSelectors
Jul 13, 2017
Merged

Reimplement content selectors#3003
tobiasdiez merged 4 commits into
masterfrom
reimplementContentSelectors

Conversation

@tobiasdiez

@tobiasdiez tobiasdiez commented Jul 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds the content selector back. They are not implemented as a dropdown option (as it was previously) but added to the list of auto completion suggestions. Viewing "content selectors" as predefined autocompletion options seemed more natural to me.

@koppor
In which order should I put the following lines to adhere to the style conventions but at the same time don't introduce illegal forward references?

   private final JScrollPane wPane = new JScrollPane(wordList);
   private final JList<String> wordList = new JList<>(wordListModel);
   private DefaultListModel<String> wordListModel = new DefaultListModel<>();
  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 12, 2017
@lenhard

lenhard commented Jul 13, 2017

Copy link
Copy Markdown
Member

I've tested it locally and like it! I was skeptical first as to how well this will actually work with autocompletion, but the solution is good. The configured selectors are directly offered the instant I click into the field in the entry editor. In my point of view, this is a full replacement for a drop down menu and way more handy.

Nevertheless, we will have to explain that to the users when we publish 4.0 :) Otherwise, they will open JabRef, see no drop down box, and get angry. So this should definitely go into a blog post.

The code looks fine overall. This is a situation where FX really beats the old swing implementation. Good job overall!

@tobiasdiez

tobiasdiez commented Jul 13, 2017

Copy link
Copy Markdown
Member Author

Thanks for the praising words 😄

@tobiasdiez tobiasdiez merged commit 983ea91 into master Jul 13, 2017
@tobiasdiez tobiasdiez deleted the reimplementContentSelectors branch July 13, 2017 10:51
@koppor koppor mentioned this pull request Jul 13, 2017
Open
Siedlerchr added a commit that referenced this pull request Jul 15, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into selectFilesDlg
f4a58c3 
* upstream/master: (30 commits)
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
  Eclipse J
  Add switch indentation for Eclipse and add some new missing formatting options
  ...
Siedlerchr added a commit that referenced this pull request Jul 15, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into sharelatex
6512fc6 
* upstream/master:
  Add preference migration for keybdingings (#3007)
  Shutdown previus AutosaveManager and BackupManager during SaveAs  (#2994)
  Run Checkstyle task after Test task (#3010)
  Mark LibraryOfCongressTest as a fetcher test (#3012)
  When browsing through the MainTable remember which EntryEditor tab was open (#3011)
  Improve performance of journal abbreviation loader (#3009)
  Update checkstyle 7.6.1 -> 8.0
  Don't abort build when there are checkstyle violations (#3006)
  Reimplement content selectors (#3003)
  Only do a back up for bigger changes or if a different field is edited (#3004)
  Listen to change events for setting dirty status of database (#3001)
  Fix #2967: MathSciNet tab works again
  Fix #2902: Tab in entry editor moves to next text area
  Fix #2946: external changes are now correctly shown in the entry editor
  Fix #2998: improve auto completion (#3002)
  Fix mac keybinding by replacing ctrl it with meta key (#3000)
  Less backups (#2995)
  [WIP] Complete rework of the auto completion (#2965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tobiasdiez @lenhard