Fix closing entry editor with ESC#2957
Merged
Merged
Conversation
Rename Escape to ESC for javafx Renamed Enum variables as key for the constant was amibiuous
tobiasdiez
approved these changes
Jul 2, 2017
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
LGTM. Can we just remove the constant thing?
| * This method returns the enum constant value | ||
| * @return | ||
| */ | ||
| public String getConstant() { |
Member
There was a problem hiding this comment.
Why do we need this "constant/key" as a unique identifier if we already have an enum?
Member
Author
There was a problem hiding this comment.
This constant is just the name of the enum value. It is used in several cases to compare bindings and to map between the settings and the enum values dynamically. It is used in KeyBindingsRepositoriy
I just renamed it, because "key" is ambigous in this content and always confused me.
Siedlerchr
added a commit
that referenced
this pull request
Jul 4, 2017
* upstream/master: Fix closing entry editor with ESC (#2957)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Escape to ESC for javafx
Renamed Enum variables as key for the constant was amibiuous
First part of #2949
Internal change only, from the new entry editor.
Edit// You may need to reset the keybinding for CLOSE_ENTRY_EDITOR in the Manage keybinding dialog, as the old stored value from the prefs no longer works for javafx.
gradle localizationUpdate?