Removed a number of warnings, added copyright etc#266
Conversation
There was a problem hiding this comment.
Should the resort list comment be removed, too? Or is the implementation below some kind of resorting?!
There was a problem hiding this comment.
I interpreted the first line as a comment and the second as a comment-out. :-) But reading it, I see your point. Will fix.
|
Other than my minor comments: 👍 |
|
When I saw OK, will try and look for those else if:s. |
|
XMPUtil is a command line tool, so I think that it makes sense to keep it as is there? |
|
I don't get the comment about |
|
@koppor The only Remove it? Leave it as is? Or use a Logger even for the CLI infos? |
|
Leave as is. Add a comment above the line (for our greppers). Add a note at our ticket to extract as external lib. That will be a standalone tool then! (lib+cmd using that lib). |
|
The main method (CLI) cannot be called at the moment. I checked 2.10 and we only shipped it without building an additional jar with a different main method. Why not just remove this then? |
|
I believe, it might be a useful tool for some power users. |
|
Maybe 😉 |
|
-> dev call :) |
|
Thank you @oscargus for this PR. |
Removed a number of warnings, added copyright etc
cb98d36691 copied .github/workflows/merge.yaml .github/workflows/sheldon.yaml from styles 62dcca65d7 Update locales-nn-NO.xml (#267) eb8587463f Update locales-nb-NO.xml (#266) bd502ffb0d Update locales-pt-PT.xml (#262) 2dcc82ced1 Update locales-it-IT.xml (#263) git-subtree-dir: buildres/csl/csl-locales git-subtree-split: cb98d366912a0c0be361880e12fbc43cef6d383e
Cleanups based on warnings, primarily:
Included copyright statements.