Disalbe Google Scholar tests on all CI environments#2654
Merged
Conversation
tobiasdiez
requested changes
Mar 16, 2017
Member
There was a problem hiding this comment.
The changes look good. In addition, I would add new tests only for the CI servers:
findSingleEntry and linkFound should throw FetcherExceptions in this case. For findSingleEntry this should already work, however https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/importer/fetcher/GoogleScholar.java#L72 throws HttpStatusException and a catcher similar to https://github.com/JabRef/jabref/blob/master/src/main/java/org/jabref/logic/importer/fetcher/GoogleScholar.java#L134 is missing.
Member
|
For me they do not fail all the time. I checked them locally. They just randomly fail?! |
Member
|
I think they fail when they are executed more than once in a couple of
minutes, e.g when you push several commits in a few seconds and each time
the build is triggered they will fail
At least that's what I noticed
|
Siedlerchr
added a commit
that referenced
this pull request
Mar 25, 2017
* upstream/master: Localization: General: French: Translation of new entries Localization: Menu: French: Translation of an entry (#2685) Fix #2680 and fix #2667: Swing errors are catched properly and without freezing (#2681) Do not log AND throw Replace misleading error message for fetcher connection error Document CrossRef test Fix subtitle detection for CrossRef fetcher Revert "Invoke LogMessages.add in JavaFX thread" Use global user agent Update mockito from 2.7.17 to 2.7.18 Move GuiAppender to GUI package Invoke LogMessages.add in JavaFX thread [WIP] Put the PDFAnnotationImporter under Test, enhance FileAnnotationTab (#2640) Fix for "Paying off technical debt: almost all utility classes have a private constructor now." (#2672) Revert "Paying off technical debt: almost all utility classes have a private constructor now. (#2649)" (#2670) Paying off technical debt: almost all utility classes have a private constructor now. (#2649) Changed codeformatting for better fxml annotation (#2668) Disalbe Google Scholar tests on all CI environments (#2654) Fix JSONException in Crossref fetcher as mentioned in #2442
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Scholar tests currently fail. This PR just follows the comment given within the test cases and disables the Google Scholar tests on all CI Servers.
We might revert this if we have time to fix Google Scholar.
Refs #2173