Cleanup window has a scrollbar now.#2614
Merged
Merged
Conversation
tobiasdiez
requested changes
Mar 5, 2017
tobiasdiez
left a comment
Member
There was a problem hiding this comment.
There seems to be a problem with the changelog. Otherwise the code looks good (besides a minor thing).
Thanks for you contribution!
| } | ||
|
|
||
| public JScrollPane getScrollPane() { | ||
| return scrollPane; |
Member
There was a problem hiding this comment.
It is probably better to return scrollPane in getPanel instead of introducing this new getter.
Contributor
Author
There was a problem hiding this comment.
The current code only contains getScrollPane(), as I removed getPanel(). I decided against returning a scrollpane in getPanel, because it makes more sense to name the method getScrollPane imho. Is this okay with you?
bacd2da to
78a6d61
Compare
Contributor
Author
|
It should be fixed now. |
b6537ca to
239d2a7
Compare
Member
|
Thanks again for your contribution! I'll merge this in as the failing Google Scholar tests are not related to your changes. |
Siedlerchr
added a commit
that referenced
this pull request
Mar 7, 2017
* upstream/master: (91 commits) fixed #2613 (#2623) Add MathSciNet as ID-based fetcher (#2621) Add icon + color and description to groups (#2612) Fixed wrong logger import (#2618) Cleanup window has a scrollbar now. (#2614) Added the locale to a newly created class Move ExportComparator and CustomExportList to the correct package (only used in preferences) Fixes displaying of Mr DLib recommendations (#2616) Fix title-related key patterns in BibtexKeyPatternUtil (#2610) Remove OrdinalsToSuperscriptFormatter from recommended biblatex save actions (#2601) Update pgjdbc to new major version Update Dependenices String Similary log4j wiremock mockito Fix exception when parsing groups which contain a top level group (#2611) Add "Remove group and subgroups" option (#2587) Fix #1104: group selection is preserved under tab change Fix several File Cleanup + Rename issues (#2415) Fixed a small error in the code comments Implement #1904: filter groups (#2588) Braces checking followup (#2598) Improve braces checking (#2593) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #2501.
gradle localizationUpdate?