Fix NPE on tab switching in EntryEditor between Mr Dlib#2567
Merged
Conversation
…tations Adjust fomratting
tobiasdiez
approved these changes
Feb 18, 2017
koppor
reviewed
Feb 20, 2017
|
|
||
| public AutoLinkAction() { | ||
| putValue(Action.SMALL_ICON, IconTheme.JabRefIcon.AUTO_FILE_LINK.getIcon()); | ||
| putValue(Action.SHORT_DESCRIPTION, Localization.lang("Automatically set file links for this entry") + " (Alt-F)"); |
Member
There was a problem hiding this comment.
If we did further code improvement, we would use the other way to show the shortcuts. Further, Alt + F is no longer the valid shortcut for that, is it?
Can you follow up in another PR?
This was referenced Mar 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and File Annotations
Adjust formatting
- [ ] Change in CHANGELOG.md described- [ ] Tests created for changes- [ ] Screenshots added (for bigger UI changes)- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)- [ ] If you changed the localization: Did you rungradle localizationUpdate?