Skip to content

CONTRIBUTING: Code formatter is no longer#2537

Merged
tobiasdiez merged 2 commits into
JabRef:masterfrom
LinusDietz:contributing-code-formatter
Feb 11, 2017
Merged

CONTRIBUTING: Code formatter is no longer#2537
tobiasdiez merged 2 commits into
JabRef:masterfrom
LinusDietz:contributing-code-formatter

Conversation

@LinusDietz

@LinusDietz LinusDietz commented Feb 10, 2017

Copy link
Copy Markdown
Member

Just stubled over the gradle format task in the CONTRIBUTING for formatting the code. However, the plugin is discontinued and was removed in 5004f1e.
Thus, I just deleted that sentence and as I was already around, I read the whole fixing minor issues in the text.

  • Change in CHANGELOG.md described -> Not necessary
  • Tests created for changes -> Not necessary
  • Screenshots added (for bigger UI changes) -> Not necessary
  • Manually tested changed features in running JabRef -> Not necessary
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate? -> Not necessary

Siedlerchr
Siedlerchr approved these changes Feb 11, 2017
View reviewed changes

@Siedlerchr Siedlerchr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution

@tobiasdiez tobiasdiez merged commit 1d3758b into JabRef:master Feb 11, 2017
@LinusDietz LinusDietz deleted the contributing-code-formatter branch February 11, 2017 12:14
Siedlerchr added a commit that referenced this pull request Feb 12, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into moveFileDir
6ee0b5d 
* upstream/master:
  CONTRIBUTING: Code formatter is no longer (#2537)
  Maintable authors (#2536)
  Add more tests for LaTeX to unicode conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LinusDietz @Siedlerchr @tobiasdiez