Check more results returned by CrossRef API for matching#2531
Merged
Conversation
Siedlerchr
reviewed
Feb 8, 2017
| } | ||
| } | ||
| } catch(JSONException ex) { | ||
| return Optional.empty(); |
Member
There was a problem hiding this comment.
Mabye useful to add a logging here in case the json format changes?
Member
There was a problem hiding this comment.
This should be detected by our Tests. Shouldn't it?
However, logging here does no harm.
Member
Author
There was a problem hiding this comment.
The test will fail yes.
tobiasdiez
approved these changes
Feb 8, 2017
Member
|
LGTM Do you want to implement #2455 as well? 😻 |
Member
|
Ok I interpret this as a "no" 😉 |
Member
Author
|
nah will do that later, maybe at jabcon. is a separate task. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2431
Changes: