Skip to content

Fix repeated escaping of % sign#2519

Merged
tobiasdiez merged 1 commit into
masterfrom
multicleanup
Feb 5, 2017
Merged

Fix repeated escaping of % sign#2519
tobiasdiez merged 1 commit into
masterfrom
multicleanup

Conversation

@Siedlerchr

Copy link
Copy Markdown
Member

Extracted Regexe in Patterns
Fix for #2451

  • Change in CHANGELOG.md described
  • Tests created for changes
    - [ ] Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
    - [ ] If you changed the localization: Did you run gradle localizationUpdate?

Extracted Regexe in Patterns
Fix for #2451
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 5, 2017

@tobiasdiez tobiasdiez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobiasdiez tobiasdiez merged commit db94341 into master Feb 5, 2017
@tobiasdiez tobiasdiez deleted the multicleanup branch February 5, 2017 13:57
Siedlerchr added a commit that referenced this pull request Feb 8, 2017
* upstream/master:
  Fix error when path is no valid directory (#2527)
  French localization: translation of a string
  French menu: localization
  Highlight groups that match any/all of the entries selected in the main table. (#2515)
  Fix % sign cleanup (#2521)
  Revert "Fix repeated escaping of % sign" (#2520)
  Fix repeated escaping of % sign (#2519)
  fix for #2482 deadlock on PDF import (#2517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants