Skip to content

Remove html code from ACM fetcher#2473

Merged
lenhard merged 1 commit into
masterfrom
acmfetcher
Jan 20, 2017
Merged

Remove html code from ACM fetcher#2473
lenhard merged 1 commit into
masterfrom
acmfetcher

Conversation

@Siedlerchr

@Siedlerchr Siedlerchr commented Jan 19, 2017

Copy link
Copy Markdown
Member

Remove html code from ACM fetcher

Fixes #2472

  • Change in CHANGELOG.md described
    - [ ] Tests created for changes
    - [ ] Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
    - [ ] If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers component: fetcher labels Jan 19, 2017
@lenhard

lenhard commented Jan 20, 2017

Copy link
Copy Markdown
Member

Looks good codewise. I tested it locally and it did not get any html code with the entry. So I am merging it right away.

@lenhard lenhard merged commit 4b65c3b into master Jan 20, 2017
@tobiasdiez tobiasdiez deleted the acmfetcher branch January 20, 2017 15:25
Siedlerchr added a commit that referenced this pull request Jan 26, 2017
* upstream/master:
  Fix medline tests...again (#2492)
  Make sure that unregistered event sources do not stop JabRef from shu… (#2487)
  Fix #2481: ClassCastException because of wrong cast (#2490)
  Catch NumberFormatException if context can't be parsed in groups (#2488)
  Improve CHANGELOG formatting
  Update guava from 20.0 to 21.0 and mockito-core from 2.5.5 to 2.6.2
  Fix aux duplicates (#2480)
  add update from DOI to the entryeditor sidebar (#2476)
  Remove obsolete import
  Add CHANGELOG entry (and one more link)
  Resolves #2309 JabRef freezes when importing unlinked PDF files into Database
  Update CHANGELOG.md
  Fixed bug when assigning refs to groups.
  emove html code from ACM fetcher before calling parser to prevent junk in bib file (#2473)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants