Add support for pages in the format 2:1-2:33#2440
Merged
Merged
Conversation
Member
|
Are These valid für |
Member
|
Sorry, was on my mobile. |
simonharrer
reviewed
Dec 30, 2016
| if (matcher.matches()) { | ||
| // replace | ||
| if(Strings.isNullOrEmpty(matcher.group(2))) { | ||
| if (Strings.isNullOrEmpty(matcher.group(3))) { |
Contributor
There was a problem hiding this comment.
Why not use named groups? Would replace the magic numbers.
Member
Author
There was a problem hiding this comment.
Done. Hope this is now ready as late self-birthday-present. 🎉
Member
Author
|
To fix codacy, I removed the |
Siedlerchr
approved these changes
Dec 31, 2016
Siedlerchr
added a commit
that referenced
this pull request
Jan 13, 2017
* upstream/master: (67 commits) Medline fix test (#2463) Fix conversion of tilde n (#2459) ctrl+f selects current query while the searchbar is focusd (#2457) incorrect log name of JabRefExecutorService (#2452) unregister DateChangeListener in manual update method (#2450) Escaping of escape symbols in the MetaData (#2445) Fix typo Update gradle from 3.2.1 to 3.3 Use instanceof Remove unused import Avoid ClassCastException in AutoCompleteListener Fix typo in CHANGELOG.md Add support for pages in the format 2:1-2:33 (#2440) L10N-ru update (#2441) Change https to http Update DBLP API endpoint Revert "Chistmas edition colors" Show development information Release v3.8.1 Result of generate-authors.sh ... # Conflicts: # CHANGELOG.md # src/main/java/net/sf/jabref/gui/date/DatePickerButton.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes JabRef#212
I worked with the article https://doi.org/10.1145/1658373.1658375 which had pages formatted as
2:1--2:33. Since I use the recommended BibTeX save actions, these pages got destroyed. This PR fixes that.gradle localizationUpdate?