Fix #2336: shutdown is working again#2338
Merged
Merged
Conversation
Contributor
|
LGTM 👍 . Unfortunately I couldn't find the case which reproduces the bug from #2336 while using Debian Jessie. |
Member
Author
|
Thanks for the review! |
Siedlerchr
added a commit
that referenced
this pull request
Dec 5, 2016
* upstream/master: builds.jabref.org: Keep html files and just remove *.exe, *.dmg, *.jar during upload of a new build Fix comment typo Fix typos in comments in .travis.yml Switch to LGoodDatePicker (#2340) Gradle build scans should only run on TravisCI, not on the other CI services Try scans.gradle.com Remove reference to GPL - we are MIT now fix date changes in medline fetcher results Fix #2336: shutdown is working again (#2338) # Conflicts: # src/main/java/net/sf/jabref/model/database/BibDatabaseContext.java
Siedlerchr
added a commit
that referenced
this pull request
Dec 5, 2016
* upstream/master: builds.jabref.org: Keep html files and just remove *.exe, *.dmg, *.jar during upload of a new build Fix comment typo Fix typos in comments in .travis.yml Switch to LGoodDatePicker (#2340) Gradle build scans should only run on TravisCI, not on the other CI services Try scans.gradle.com Remove reference to GPL - we are MIT now fix date changes in medline fetcher results Fix #2336: shutdown is working again (#2338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #2336 (at least it works for me now).
I have no real idea where the problem was but I suspect that sometimes the BackupManager was not registered properly as a listener. Now the backup manager registers itself in the constructor. Moreover, the backup manager is allways initialized although the db may be shared or does not yet have a filepath attached to it.
Other changes are only minor refactorings.