Add complete entries with fetched infos#2307
Conversation
lenhard
left a comment
There was a problem hiding this comment.
I have tested this locally and it works nicely! I have just two minor comments in the code that should be fixable easily.
| })); | ||
| } | ||
| JButton fetcherButton = new JButton(IconTheme.JabRefIcon.REFRESH.getIcon()); | ||
| fetcherButton.setToolTipText(Localization.lang("Update with bibliographic information from the web.")); |
There was a problem hiding this comment.
Imho, there is no reason for adding the period in the end. JabRef is not consistent in this, some tool tips end with periods and some do not. In my point of view, punctuation is only needed if there is a block of text for the tool tip. If it is a single sentence, no punctuation looks better.
So please remove that one :)
There was a problem hiding this comment.
As this is a tooltip, the final dot should really be removed.
|
|
||
| @Override | ||
| public void action() throws Throwable { | ||
| { |
There was a problem hiding this comment.
What is the reason for this additional level of indentation?
|
Sorry I don't know if this is the right place to ask my question, that is, whether it is possible to fetch the abstract when clicking "Get Bibtex data from DOI" (along with other data Author/Journal, etc.). Thanks! |
|
@onewiki This is not possible, as the information for DOIs are resolved using crossref.org. And crossref.org does not provide abstracts, see this example: http://search.crossref.org/?q=10.2331%2Fsuisan.32.804 |
|
@matthiasgeiger Thanks for explaining. |
|
@matthiasgeiger Sorry to bother you with another question (since you are knowledgeable on DOI etc.): do all articles (in social science) have DOIs, or only the ones published after year 2000? |
|
@matthiasgeiger This is not really right: CrossRef does provide a way to get the abstract, however, this is only possible using the XML version, see the comment: I recently checked that, because of a feature request in the forum: @onewiki It depends which article a DOI has. I recently had one article from 1987 in the area of computer science which had a DOI assigned. As Publishers have to pay a fee for using a DOI, it might be that not all are willing to pay it, especially OpenAcces models. |
|
Generally not all academic works have DOIs, e.g., Technical Reports published at my university only have a ISSN for the series and a "URN" as an identifier. Also workshop and conference publications exist without DOIs. Most journal articles however have DOIs - but there are also journals not using DOIs. In my main database there are some articles published prior 2000 which have a DOI, e.g.: http://doi.org/10.1145/69605.2085 - but most older articles don't have DOIs. |
|
@Siedlerchr |
|
@onewiki The hint with the xml was for @matthiasgeiger. It's an implementation detail for calling the API service from JabRef, you can't do anything with. |
|
@Siedlerchr Are you saying I have to wait for the Jabref team to incorporate this feature into the program (so that it will be available in a future version)? |
|
@tobiasdiez Please fix the few very minor things mentioned above, merge the language files and then this is ready to go into master! |
0d880a4 to
e8acee7
Compare
* upstream/master: Add initial .editorconfig (#2332) Add complete entries with fetched infos (#2307) Google Scholar is also blocked on SnapCI Quick fix to fix failing travis Add Objects.requireNonNull to track down test issue on travis Remove obsolete xcf file Update to latest travis environment - see https://docs.travis-ci.com/user/build-environment-updates/2016-12-01/
Bibliographic information from web resources can now be used to complete existing entries. This functionality can be accessed via a new button in the entry editor.
I think also the IdBasedFetcher like DOI can implement the
EntryBasedinterface and thus can be made accessible to this update function. It that case,FetchAndMergeWorkermay be replaced by the newEntryFetchAndMergeWorker. Something for a new PR through.gradle localizationUpdate?