Skip to content

[WIP] Integrate BibSonomy Plugin#2157

Closed
zesaro wants to merge 63 commits into
JabRef:masterfrom
zesaro:bibsonomy
Closed

[WIP] Integrate BibSonomy Plugin#2157
zesaro wants to merge 63 commits into
JabRef:masterfrom
zesaro:bibsonomy

Conversation

@zesaro

@zesaro zesaro commented Oct 12, 2016 •
edited by koppor
Loading

Copy link
Copy Markdown
Contributor

We try to offer the latest build at http://builds.jabref.org/bibsonomy/. Feel free to comment on the functionality in this PR.

BibSonomy is a tool for maintaining references. PUMA is the instance of the University of Stuttgart. For more information, check the related work of CloudRef.

Example usage of BibSonomy:

grafik

Aim: Get first working version into JabRef again, do some marketing, and attract a maintainer for that functionality.

The aim of this pull request is to integrate the BibSonomy Plugin from JabRef 2.11 into the actual JabRef master branch. You can run BibSonomy from the menubar (between Tools and Options), search for entries and fetch them. There are still parts in the code which has to be updated. Since 2.11 much has changed. For example the MetaData which I have to investigate.

I am looking forward to hear your feedback.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • If you changed the localization: Did you run gradle localizationUpdate?

Notes

  • BibSonomy seems to use following fields: interhash;intrahash;keywords;groups;privnote. Special handling for them is removed in this PR as it is unclear how they are used.

@zesaro zesaro force-pushed the bibsonomy branch 2 times, most recently from 42694cc to e415619 Compare October 15, 2016 16:53
@tobiasdiez

tobiasdiez commented Oct 16, 2016

Copy link
Copy Markdown
Member

Does it make sense to integrate the "Search BibSononym" feature as a fetcher?

@koppor

koppor commented Oct 16, 2016

Copy link
Copy Markdown
Member

Here a screenshot:

grabbed_20160928-231813

@koppor koppor added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Oct 24, 2016
@koppor koppor mentioned this pull request Oct 29, 2016
Closed
13 tasks
@lenhard

lenhard commented Nov 18, 2016

Copy link
Copy Markdown
Member

What is the status / plan here? I am not quite sure as to what questions are waiting for being answered here?

The size of the PR is a little scary. 5000+ lines are well above what we can meaningfully review.

@koppor

koppor commented Nov 18, 2016

Copy link
Copy Markdown
Member

@zellerdev is going to provide an update on Tuesday. The size of the code cannot be reduced easily, because we include a plugin, which is large by itself.

See f8da659 and https://bitbucket.org/bibsonomy/bibsonomy-jabref-plugin/wiki/Home

This PR is a huge step to fix #152

@zesaro zesaro force-pushed the bibsonomy branch 2 times, most recently from 3a43cdf to 3e4c203 Compare November 22, 2016 00:53
zesaro added 14 commits November 22, 2016 02:54
@koppor koppor removed the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Dec 16, 2016
@zesaro
Merge remote-tracking branch 'upstream/master' into bibsonomy
890d54f 
# Conflicts:
#	src/main/java/net/sf/jabref/model/metadata/MetaData.java
@koppor

koppor commented Dec 19, 2016

Copy link
Copy Markdown
Member

Status: Functionality works. Also with PUMA. Others should test it, too.

Open issues:

  • Code refactoring
  • Tests
  • Check whether the handling of Metadata is correct

@koppor koppor added the on-hold label Feb 5, 2018
@koppor koppor closed this Feb 5, 2018
koppor added 6 commits May 11, 2018 08:58
@koppor
Add missing break statements (and reformat)
f5a473c
@koppor
Minor stylistic improvements
ba544bb
@koppor
Move dialog into a warning at the preferences
c499265
@koppor
Merge remote-tracking branch 'origin/master' into bibsonomy
0237a00 
# Conflicts:
#	build.gradle
#	external-libraries.txt
#	src/main/java/org/jabref/gui/IconTheme.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/preftabs/FontSelectorDialog.java
#	src/main/java/org/jabref/model/strings/StringUtil.java
#	src/main/resources/l10n/JabRef_da.properties
#	src/main/resources/l10n/JabRef_de.properties
#	src/main/resources/l10n/JabRef_en.properties
#	src/main/resources/l10n/JabRef_es.properties
#	src/main/resources/l10n/JabRef_fa.properties
#	src/main/resources/l10n/JabRef_fr.properties
#	src/main/resources/l10n/JabRef_in.properties
#	src/main/resources/l10n/JabRef_it.properties
#	src/main/resources/l10n/JabRef_ja.properties
#	src/main/resources/l10n/JabRef_nl.properties
#	src/main/resources/l10n/JabRef_no.properties
#	src/main/resources/l10n/JabRef_pt_BR.properties
#	src/main/resources/l10n/JabRef_ru.properties
#	src/main/resources/l10n/JabRef_sv.properties
#	src/main/resources/l10n/JabRef_tr.properties
#	src/main/resources/l10n/JabRef_vi.properties
#	src/main/resources/l10n/JabRef_zh.properties
#	src/test/java/org/jabref/logic/formatter/FormatterTest.java
@koppor
Compile fixes
022eb9c
@koppor
Remove unused variables
0d09f8e
@koppor koppor reopened this May 31, 2018
@koppor koppor removed the freeze label May 31, 2018
@koppor

koppor commented May 31, 2018

Copy link
Copy Markdown
Member

Blocked by https://bitbucket.org/Jerady/fontawesomefx/pull-requests/14/add-cancel-icon/diff.

@tobiasdiez

tobiasdiez commented May 31, 2018

Copy link
Copy Markdown
Member

Maybe @halirutan can add the cancel icon to our own font (or we just choose a different icon for the time being...)

@halirutan

halirutan commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

@koppor @tobiasdiez Here #4069

@tobiasdiez

tobiasdiez commented Jun 1, 2018

Copy link
Copy Markdown
Member

@halirutan perfect! Thanks.
@koppor now you need to base on the maintable branch ;-)

@koppor koppor mentioned this pull request Jun 3, 2018
Merged
@tobiasdiez

tobiasdiez commented Oct 9, 2018

Copy link
Copy Markdown
Member

Any update? I'll mark this as on-hold for the moment. Feel free to merge the latest master, update the code and reopen.

@tobiasdiez tobiasdiez closed this Oct 9, 2018
@koppor

koppor commented Oct 10, 2018

Copy link
Copy Markdown
Member

I am not able to code JavaFX, so we really need help from the community. Maybe @zesaro wants to learn JavaFX and bring JabRef a huge step forward!

@zesaro

zesaro commented Oct 14, 2018

Copy link
Copy Markdown
Contributor Author

I am always interested in learning new things. Currently I'm not up to date with this PR. Is this meant to update this PR or address issues in the Rework?
But it eventually would be a slow process. What about the JavaFX Team from @JabRef/stupro ? 😄

@zesaro

zesaro commented Mar 13, 2019

Copy link
Copy Markdown
Contributor Author

Is this still relevant? What has to be done here? Something with JavaFX?
I'd love to finish what I started 😅

@koppor

koppor commented Mar 13, 2019 via email

Copy link
Copy Markdown
Member

@koppor koppor mentioned this pull request Dec 22, 2019
Closed
@koppor koppor mentioned this pull request Jan 28, 2020
Open
@krisgun krisgun mentioned this pull request Feb 24, 2020
Open
@stevensdavid stevensdavid mentioned this pull request Feb 25, 2020
Open
@zesaro

zesaro commented Jun 3, 2020

Copy link
Copy Markdown
Contributor Author

Is the bibsonomy-rest-client still usable with the current version of JabRef? I didn't work with Java for a long time now and never touched the new modules.
But I was curious. So I checked out a new branch from the current master and updated build.gradle to use the dependencies for the current bibsonomy-rest-client (3.9.2). Basically a two-liner.
But this seems to bite with some modules. At least I can't execute the run command successfully anymore.
Amy I missing something?

@zesaro zesaro deleted the bibsonomy branch January 16, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@koppor koppor koppor left review comments

Assignees

@koppor koppor

@zesaro zesaro

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zesaro @tobiasdiez @koppor @lenhard @halirutan @tschechlovdev