Additional "Cancel" and "VSCode" icon#4069
Conversation
| SET_ALL("\ue90c"); | ||
| SET_ALL("\ue90c"), | ||
| VSCODE("\ue90d"), | ||
| CANCEL("\ue90e"); |
There was a problem hiding this comment.
I think, we could have reused the original material design font without copy and pasting and icon? Let's see, how I can include the new icon, because constructor of JabRefIcon needs a MaterialDesignIcon.
There was a problem hiding this comment.
@koppor This is on the maintable-beta branch...there JabRefIcon is an interface.
There was a problem hiding this comment.
@koppor That was a design-flaw I fixed for the maintable branch. It basically only needs to implement the GlyphIcons interface. In essence it was a more or less simple refactoring and now the JabRefIcons constructor can take both our Icons and MD icons. Look at the org.jabref.gui.icon package on the maintable branch. Maybe you can cherry pick it somehow.
In addition to the new icons, I have removed the
lcdantialiasing for icons. We discussed several times that this setting makes icons crispy on Linux while it doesn't seem to have a major effect on other operating systems.