Found entries will be shown when dropping a pdf with xmp meta data#2150
Conversation
|
Could you also treat the dialog which appears when dropping on an entry in the entry table:
|
|
Apart from my question: LGTM 👍 |
|
I also added the found entries to the gerneral pdf import dialog and updated the description of this pr. |
|
Please push and do not include 2f3c47f as this seems to be from another PR.
|
|
Sry I guess I forgot to push... |
|
Looks good! Would it make sense to show the resulting entry independent of which option is selected in the "Import metadata from PDF" dialog? (The heading of the source box needs to be changed in that case.) |
|
@oscargus what do you mean by that? The entry from the XMP metadata will always be shown if an entry is found, regardless of what is selected. The "XMP-metadata" section is only hidden if no entry has been found. |
|
I'm thinking that it can always be shown and it shows whatever entry is generated. For a blank it may be: and so on. In this way, the user knows what the resulting entry will be. No idea how easy it is (i.e., when the actual entry is created and therefore if one can get hold of it to show) and if it should be in this PR. Just seemed like a nice extension to the general idea of this PR. |
|
I get the entries from the |
|
Not in that case. I'm more thinking if you select one of the other import
cases with the radio buttons (blank with link, content). Not sure how to
handle all possible outcomes though. What happens if you select XMP and
there is no XMP data? Anything gets added?
You can leave it for now, if you want to, as I do not know how realistic it
is to implement it.
|
|
XMP can not be selected if there is no xmp metadata. :) On Oct 11, 2016, 21:30, at 21:30, Oscar Gustafsson notifications@github.com wrote:
|
|
OK! Then that part is solved. :-) |
* upstream/master: (24 commits) hotfix NPE in the main table (#2158) Enhance side pane toggle (#1605) Added gray background text to authors field to assist newcomers (#2147) Rewrite google scholar fetcher to new infrastructure (#2101) Found entries will be shown when dropping a pdf with xmp meta data (#2150) Japanese translation (#2155) Add shortcuts to context menu (#2131) [WIP] Doi resolution ignore (#2154) Fix DuplicationChecker and key generator (#2151) just close popup on first ESC keep entry in sight Fix isSharedDatabaseAlreadyPresent check. don't change entry after search if editing an entry (#2129) Change download URL to downloads.jabref.org (#2145) fix switching edited textfield in the entry editor with TAB (#2138) Update me.champeau.gradle.jmh' version from 0.3.0 to 0.3.1 Update install4j plugin from 6.1.2 to 6.1.3 Remove gradle plugin com.github.youribonnaffe.gradle.format as it is deprecated and the config uses a non-existing file Update gradle from 3.0 to 3.1 Fix changing the font size not working when importing preferences (#2069) ... # Conflicts: # src/main/java/net/sf/jabref/gui/externalfiles/DroppedFileHandler.java # src/main/java/net/sf/jabref/gui/importer/fetcher/GoogleScholarFetcher.java
When dropping a pdf with xmp meta data to the "File" field of an entry the information dialog should diplay the found entries. See JabRef#5 for reference.
The general pdf import dialog which is shown when dropping a pdf somewhere to the main table also show the found entries.