Skip to content

Make all files selectable in file chooser dialogs#2094

Merged
stefan-kolb merged 2 commits into
JabRef:masterfrom
chochreiner:fixFileChooser
Oct 14, 2016
Merged

Make all files selectable in file chooser dialogs#2094
stefan-kolb merged 2 commits into
JabRef:masterfrom
chochreiner:fixFileChooser

Conversation

@chochreiner

@chochreiner chochreiner commented Sep 29, 2016

Copy link
Copy Markdown
Contributor

make all files selectable in filechooser

fixed #2021

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@Siedlerchr Siedlerchr changed the title fixed #2021 Make all files selectable in file chooser dialogs Sep 29, 2016
@chochreiner chochreiner force-pushed the fixFileChooser branch 2 times, most recently from f7eba83 to 039bd9c Compare October 3, 2016 18:45
@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 14, 2016
@stefan-kolb

Copy link
Copy Markdown
Member

Does this make the . file filter the default file filter (selected)? (https://docs.oracle.com/javase/7/docs/api/javax/swing/JFileChooser.html#setAcceptAllFileFilterUsed(boolean))

@chochreiner

Copy link
Copy Markdown
Contributor Author

no, the default one is still the specific one (e.g. xml)

@stefan-kolb

Copy link
Copy Markdown
Member

Great, thanks Christoph!

@stefan-kolb stefan-kolb merged commit e49df1c into JabRef:master Oct 14, 2016
Siedlerchr added a commit that referenced this pull request Oct 15, 2016
* upstream/master:
  Code cleanups (#2141)
  Remove obsolete string in .mailmap
  Update .mailmap and AUTHORS
  Implementation of autosave & backup feature (#2118)
  Make all files selectable in file chooser dialogs (#2094)
  Fix group drag and drop (#2161)
  Change donation badge and point to https://donations.jabref.org

# Conflicts:
#	src/main/java/net/sf/jabref/logic/util/OptionalUtil.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot import non-XML preferences, cannot import BibTeX key generator preferences

2 participants