Other fields fix and changes#2075
Conversation
|
I'm sorry, but I am not sure if I get/understand your changes, because what does "OtherFields" refer to? I have the following tabs. in BibTex: Deprecated fields exist for bibtex compatibility, when you import an entry you often get in bibtex. |
|
I think I found the bug in #2064. It was not a regression. A new entry editor was not instantiated on changing an entry of the same type. So some "other fields" were not displayed. |
|
Please set label "ready-for-review". Thanks. |
Siedlerchr
left a comment
There was a problem hiding this comment.
In general the code looks good. I have only no clue for which reason the entry editor originally was cached and if the removal has any performance aspects.
|
The idea was originally to have a better performance. So the entry editor is retained for the same type. This is not a good idea. The entry editor needs to be build completetely new in all cases, because the new entry can have some additional (layout changing) other fields. |
|
So the whole |
I think, |
|
I've checked the code. @tobiasdiez you are right. The whole entry editor caching (for each type) can be removed. I have no performance issues with my databases. |
|
I noticed a very small latency if you quickly switch from editing one entry to another (for example with the arrow keys). But as I don't think this is a big deal, I'll merge this PR now. |
|
Yes, fast scrolling of the entries causes a small latency and moderate CPU usage. But I think, this is no problem. I have an idea for caching the entry editor: entry editor A -> B -> A. A can be cached. But this takes real effect only on heavy usage of the database. |
|
Or cache based on the "properties" of the entry. One could generate a
unique ID for each entry property. -- Property: entry type, other fields.
(future: hadPDFAttached) @Braunch
|
|
The problem is generating the textfields. So especially in biblatex mode there are around 80 fields which are generated every time. I would not cache the whole editor but just generate the textboxes when the tab is focused. |
|
The other field tab is optional (No field -> No tab). I would prefer to create the other fields tab always (No field -> Empty tab). The advantage is, that every entry editor has always the same layout of the tabs. This preserves the active (other fields) tab on changing the entry. |
* Other fields changes * Fix other fields * Entry editors cache removed

These are the claimed improvements:
other fields(BibTeX)other fields(BibLaTeX)See: #2064