Fixing bug 1282#198
Conversation
Inserting a conditional case to avoid the addition of extra "\" to existing text in case of PGSQL
|
The thing is, we want to improve our code quality. Could you use a formatter as described in CONTRIBUTING.md? May I also ask to remove commit a6919e6 from here as it has nothing to do with this PR? You can open a separate PR for updating the translation :). Sorry for being picky, but we are really trying to improve our code quality. |
|
OK Oliver, Igor Fabio Steinmacher, Ph.D. On Thu, Oct 1, 2015 at 6:42 PM, Oliver Kopp notifications@github.com
|
|
Looks good to me. |
There was a problem hiding this comment.
I would love to see a comment here why this is necessary. So future developers can instantly see the reason behind this code and remove it if behaviour has changed.
Appending to the pull request to fix the issue 1282 (SF). Just adding comments
|
Last thing: Could you add a CHANGELOG entry? 😇 |
|
Did it. |
Duplicate PR #59