Added error dialog when setting invalid main file directory#1921
Merged
Conversation
4375553 to
353df80
Compare
Member
|
LGTM 👍 |
353df80 to
6a80748
Compare
Siedlerchr
added a commit
that referenced
this pull request
Sep 11, 2016
* master: Remove obsolete wrapper task Added error dialog when setting invalid main file directory (#1921) Add filteringCharset = 'UTF-8' (#1945) Include https://github.com/grimes2 Searchbar across all bib files instead each having its own (#1549) Some OO/LO cleanups (#1927) Update link Removed external dependency in logic (#1934)
Siedlerchr
added a commit
to Siedlerchr/jabref
that referenced
this pull request
Sep 11, 2016
* master: Remove obsolete wrapper task Added error dialog when setting invalid main file directory (JabRef#1921) Add filteringCharset = 'UTF-8' (JabRef#1945) Include https://github.com/grimes2 Searchbar across all bib files instead each having its own (JabRef#1549) Some OO/LO cleanups (JabRef#1927) Update link Removed external dependency in logic (JabRef#1934)
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many users set file directories by copy pasting the path and not by opening the file chooser. This means invalid paths could be set in preferences -> File -> main file directory
See JabRef#109 for more information.
Now the preferences tab won't save an invalid path anymore and notifies the user about it.
Also there is now an error message when trying to download a file to a directory which does not exist or can not be written to.