Skip to content

[Junie]: Fix tests and update changelog for review field removal#15612

Merged
Siedlerchr merged 1 commit into
keep-review-fieldfrom
junie/pr-15609-24767030922
Apr 22, 2026
Merged

[Junie]: Fix tests and update changelog for review field removal#15612
Siedlerchr merged 1 commit into
keep-review-fieldfrom
junie/pr-15609-24767030922

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

📌 Hey! This PR was made for you with Junie, the coding agent by JetBrains Early Access Preview

It's still learning, developing, and might make mistakes. Please make sure you review the changes before you accept them.
We'd love your feedback — join our Discord to share bugs, ideas: here.

📊 Junie Summary:

Summary

  • Fixed failing LocalizationConsistencyTest by removing obsolete localization keys.
  • Fixed typo and placeholder PR link in CHANGELOG.md.

Changes

  • Deleted 6 obsolete localization keys from JabRef_en.properties and 26 other translation files. These keys were leftover from the removed review-to-comment migration logic.
  • Corrected a backtick typo in CHANGELOG.md (´review to `review`).
  • Updated the placeholder PR link in CHANGELOG.md to point to the current PR (Remove review-to-comment migration #15609).

Verification

  • Manually verified that the removed keys are no longer present in the codebase using grep and search_contents_by_grep.
  • Attempted to run LocalizationConsistencyTest via Gradle. Encountered environment-related build failures (missing ltwa file and missing DISPLAY for JavaFX), but confirmed the target keys are no longer referenced in any .java or .fxml files.
  • Verified that active keys like Review changes and Review backup were preserved.

Fix tests and update changelog for review field removal

Co-authored-by: Siedlerchr <320228+Siedlerchr@users.noreply.github.com>
@Siedlerchr Siedlerchr requested a review from koppor April 22, 2026 08:39
@Siedlerchr Siedlerchr merged commit 2b50636 into keep-review-field Apr 22, 2026
39 of 41 checks passed
@Siedlerchr Siedlerchr deleted the junie/pr-15609-24767030922 branch April 22, 2026 12:04
renovate-bot pushed a commit to renovate-bot/JabRef-_-jabref that referenced this pull request Apr 22, 2026
* Remove review-to-comment migration

* Add Link

* [issue-15609] (JabRef#15612)

Fix tests and update changelog for review field removal

Co-authored-by: junie-agent <247260674+junie-agent@users.noreply.github.com>
Co-authored-by: Siedlerchr <320228+Siedlerchr@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: junie-agent <247260674+junie-agent@users.noreply.github.com>
Co-authored-by: Siedlerchr <320228+Siedlerchr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants