Reset and Import for abbreviation prefs and small fixes by calixtus · Pull Request #15503 · JabRef/jabref

calixtus · 2026-04-06T20:36:18Z

Related issues and pull requests

Follow-up #15395

PR Description

Fixed import and reset for JournalAbbreviationPreferences
Fixed issue with FJournal field not set in preferences dialog
Fixed proxy password not read from keyring

Steps to test

Open File > Preferences
Clear or import preference

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[.] I added JUnit tests for changes (if applicable)
[.] I added screenshots in the PR description (if change is visible to the user)
[.] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
[.] I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
[.] I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

…ournal not read from preferences

qodo-free-for-open-source-projects · 2026-04-06T20:36:41Z

Review Summary by Qodo

Fix import and reset for JournalAbbreviationPreferences
🐞 Bug fix

Walkthroughs

Description

• Fixed import and reset functionality for JournalAbbreviationPreferences
• Added default constructor and getDefault() method to JournalAbbreviationPreferences
• Implemented setAll() method for proper preference synchronization
• Fixed FJournal field not being restored when loading preferences
• Removed hardcoded default values from JabRefCliPreferences initialization

Diagram

flowchart LR
  A["JournalAbbreviationPreferences"] -->|"add default constructor"| B["getDefault()"]
  A -->|"add setAll()"| C["Synchronize preferences"]
  D["JabRefCliPreferences"] -->|"use getDefault()"| B
  D -->|"call setAll()"| C
  D -->|"clear()"| E["Reset to defaults"]
  D -->|"importPreferences()"| F["Load from backing store"]
  G["JournalAbbreviationsTabViewModel"] -->|"setValues()"| H["Restore FJournal field"]

File Changes

1. jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java 🐞 Bug fix +3/-1

Initialize FJournal field from preferences
• Added initialization of useFJournal property in setValues() method
• Changed unused parameter to underscore in onSuccess lambda
jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java

2. jablib/src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java ✨ Enhancement +16/-0

Add default constructor and synchronization methods
• Added private no-argument constructor with default values
• Added setAll() method to synchronize preferences from another instance
• Added getDefault() static method to provide default preferences
jablib/src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java

3. jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java 🐞 Bug fix +14/-11

Fix journal preferences import, reset, and initialization

• Removed hardcoded default values for EXTERNAL_JOURNAL_LISTS and USE_AMS_FJOURNAL
• Refactored getJournalAbbreviationPreferences() to use new
 getJournalAbbreviationPreferencesFromBackingStore() method
• Added getJournalAbbreviationPreferencesFromBackingStore() helper method with fallback defaults
• Fixed clear() method to reset JournalAbbreviationPreferences to defaults
• Fixed importPreferences() method to properly load journal preferences from backing store
• Reorganized code with region markers for better structure

jablib/src/main/java/org/jabref/logic/preferences/JabRefCliPreferences.java

qodo-free-for-open-source-projects · 2026-04-06T20:36:42Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0) 🎨 UX Issues (0)

📘\ ⚙ Maintainability (1)

1. Trivial constructor argument comments 📘 ⚙

Description

The new JournalAbbreviationPreferences() constructor adds inline comments that only restate
argument names, reducing signal-to-noise. Comments should explain intent/rationale instead of
paraphrasing code.

Code

jablib/src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java[R21-25]

+    private JournalAbbreviationPreferences() {
+        this(
+                List.of(), // externalJournalLists
+                true       // useFJournalField
+        );

Evidence
PR Compliance ID 7 requires that new comments explain the “why” rather than restating code. The
added comments // externalJournalLists and // useFJournalField merely label the already-obvious
arguments.
AGENTS.md
jablib/src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java[21-25]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The private default constructor adds comments that restate argument names (trivial comments).
## Issue Context
Project guidance requires comments to explain rationale/intent (“why”), not paraphrase code.
## Fix Focus Areas
- jablib/src/main/java/org/jabref/logic/journals/JournalAbbreviationPreferences.java[21-25]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. ~~Whitespace-only line added~~ ☑ 📘 ⚙

Description

A whitespace-only blank line was added, introducing unnecessary formatting churn. This makes diffs
noisier without functional benefit.

Code

jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java[113]
+        

Evidence
PR Compliance ID 3 requires avoiding unrelated formatting changes. The added blank line at
setValues() contains whitespace only and does not contribute to the functional change.
AGENTS.md
jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java[113-113]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A whitespace-only blank line was introduced in `setValues()`, creating unnecessary formatting churn.
## Issue Context
The compliance checklist asks to keep diffs minimal and avoid unrelated reformatting.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/preferences/journals/JournalAbbreviationsTabViewModel.java[113-113]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

Fixed reset and import of JournalAbbreviationPreferences and fixed FJ…

680609c

…ournal not read from preferences

calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers dev: code-quality Issues related to code or architecture decisions component: preferences labels Apr 6, 2026

calixtus and others added 2 commits April 6, 2026 22:42

Fix password handling in getProxyPreferences

194314b

Update JournalAbbreviationsTabViewModel.java

79fc847

calixtus changed the title ~~Reset and Import for abbreviation prefs~~ Reset and Import for abbreviation prefs and small fixes Apr 6, 2026

calixtus enabled auto-merge April 7, 2026 06:05

Siedlerchr approved these changes Apr 7, 2026

View reviewed changes

calixtus added this pull request to the merge queue Apr 7, 2026

github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Apr 7, 2026

Merged via the queue into main with commit 4995a15 Apr 7, 2026
74 of 76 checks passed

calixtus deleted the journal-prefs-reset branch April 7, 2026 19:04

calixtus mentioned this pull request Apr 8, 2026

Fix reset and import for Library, DOI, Owner, Timestamp and Remote Preferences #15514

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reset and Import for abbreviation prefs and small fixes#15503

Reset and Import for abbreviation prefs and small fixes#15503
calixtus merged 3 commits into
mainfrom
journal-prefs-reset

calixtus commented Apr 6, 2026 •

edited

Loading

Uh oh!

qodo-free-for-open-source-projects Bot commented Apr 6, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Apr 6, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

calixtus commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

qodo-free-for-open-source-projects Bot commented Apr 6, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

calixtus commented Apr 6, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Apr 6, 2026 •

edited

Loading