Cover images download: New toggle button in quick settings by jonas-ee · Pull Request #15322 · JabRef/jabref

jonas-ee · 2026-03-11T17:49:19Z

Related issues and pull requests

Closes a private issue of @koppor

PR Description

This is the result of a mob programming session at Javaland. The setting to download cover images should be show as a toggle button on the initial tab. This is done to make users aware of this opt-in feature.

Steps to test

To test this you need to start the application and check if there is a new toggle button on the tab that opens when you open the application. The same setting can also be accessed via the settings menu and changing that settings should also change the new toggle button and vice versa. You could also check if the document preview shows the cover images but this would require a document to generate a preview for and might be out of scope for this issue.

Checklist

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
[/] I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
[/] I added a screenshot in the PR description showing a library with a single entry with me as author and as title the issue number
I described the change in CHANGELOG.md in a way that can be understood by the average user (if change is visible to the user)
I checked the user documentation for up to dateness and submitted a pull request to our user documentation repository

github-actions · 2026-03-11T17:49:30Z

Hey @jonas-ee! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing. We also use Qodo for review assistance. It will update your pull request description with a review help and offer suggestions to improve the pull request.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. You can read about the whole pull request process in our contribution guide.

Please ensure that your pull request is in line with our AI Usage Policy and make necessary disclosures.

qodo-free-for-open-source-projects · 2026-03-11T17:49:37Z

Review Summary by Qodo

Add cover images download toggle to quick settings

✨ Enhancement

Walkthroughs

Description

• Added toggle button for cover images download in quick settings
• Binds toggle to existing preview preferences property
• Added localization string for new toggle button
• Updated changelog with feature description

Diagram

flowchart LR
  QS["Quick Settings UI"] -->|adds| CIT["Cover Images Toggle"]
  CIT -->|binds to| PP["Preview Preferences"]
  L10N["Localization"] -->|provides label| CIT
  CHANGELOG["CHANGELOG.md"] -->|documents| QS

File Changes

1. jabgui/src/main/java/org/jabref/gui/welcome/components/QuickSettings.java ✨ Enhancement +6/-0

Add cover images download toggle to UI

• Created new ToggleSwitch for cover images download feature
• Bound toggle to preferences.getPreviewPreferences().shouldDownloadCoversProperty()
• Added toggle to VBox layout alongside HTTP server toggle
• Applied consistent styling with max width and padding

jabgui/src/main/java/org/jabref/gui/welcome/components/QuickSettings.java

2. CHANGELOG.md 📝 Documentation +1/-0

Document cover images toggle feature
• Added entry documenting new quick settings toggle for cover images download
CHANGELOG.md

3. jablib/src/main/resources/l10n/JabRef_en.properties Localization +1/-0

Add localization for cover images toggle
• Added English localization string for cover images download toggle label
jablib/src/main/resources/l10n/JabRef_en.properties

qodo-free-for-open-source-projects · 2026-03-11T17:49:38Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (2) 📎 Requirement gaps (0)

1. Duplicate cover download label 📘 Rule violation ✓ Correctness

Description

A new localization string Enable cover images download is introduced even though a very similar
existing string Download cover images already exists, increasing translation duplication and
inconsistency risk. Reusing the existing key/string would better align with localization reuse
expectations.

Code

jabgui/src/main/java/org/jabref/gui/welcome/components/QuickSettings.java[68]
+        ToggleSwitch coverImagesDownloadToggle = new ToggleSwitch(Localization.lang("Enable cover images download"));

Evidence
PR Compliance ID 25 requires reusing and grouping localization strings rather than introducing
near-duplicates. The PR adds and uses a new string (Enable cover images download) while an
existing string (Download cover images) is already present in the localization bundle, indicating
a near-duplicate.
AGENTS.md
jabgui/src/main/java/org/jabref/gui/welcome/components/QuickSettings.java[68-68]
jablib/src/main/resources/l10n/JabRef_en.properties[3477-3478]
jablib/src/main/resources/l10n/JabRef_en.properties[1578-1578]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A new user-facing localization string (`Enable cover images download`) was added even though a very similar existing string (`Download cover images`) already exists. This creates translation duplication and can lead to inconsistent UI wording across screens.
## Issue Context
The UI toggle label in `QuickSettings` uses `Localization.lang(&amp;quot;Enable cover images download&amp;quot;)`, and a new entry was added to `JabRef_en.properties`. There is already an existing localization entry `Download cover images` in the same properties file.
## Fix Focus Areas
- jabgui/src/main/java/org/jabref/gui/welcome/components/QuickSettings.java[68-71]
- jablib/src/main/resources/l10n/JabRef_en.properties[3477-3479]
- jablib/src/main/resources/l10n/JabRef_en.properties[1576-1580]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. ~~Changelog entry lacks issue link~~ ☑ 📘 Rule violation ✓ Correctness

Description

The new CHANGELOG.md entry omits the issue/PR reference and uses awkward phrasing (`quick
setting, cover images download`) compared to surrounding entries. This reduces professionalism and
traceability of user-facing release notes.

Code

CHANGELOG.md[18]

+- We added a quick setting toggle to enable cover images download

Evidence

PR Compliance ID 37 requires user-facing text to be professional and precise and to include required
issue references when applicable. The added changelog line is user-facing, lacks the common issue
reference pattern used by neighboring entries, and contains imprecise phrasing.

CHANGELOG.md[16-18]
Best Practice: Learned patterns

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The added `CHANGELOG.md` entry is missing an issue/PR reference and the wording is imprecise (`quick setting`, `cover images download`).
## Issue Context
Other entries in the same section include issue references (e.g., `[#15134]`, `[#13821]`). This entry should match that convention and be proofread.
## Fix Focus Areas
- CHANGELOG.md[16-19]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

ⓘ The new review experience is currently in Beta. Learn more

koppor · 2026-03-11T17:53:34Z

This was part of the #javaland session by @Maran23.

https://meine.doag.org/events/javaland/2026/agenda/#agendaId.7512

koppor · 2026-03-11T17:54:30Z

@jonas-ee: It should be possible to do ./gradlew :jabgui:run from the command line (or go to the respective IntelliJ task)

Maran23 · 2026-03-11T22:13:53Z

Thanks to both of you, @jonas-ee and @koppor! You even added it to the changelog, nice! I will do a retest tomorrow evening, when home. @koppor need to decide if this should belong to this changelog section and if the button text is fine (We used nearly the same text as in the options).

jonas-ee · 2026-03-11T22:25:17Z

@jonas-ee: It should be possible to do ./gradlew :jabgui:run from the command line (or go to the respective IntelliJ task)

It worked now. I think Intellij just need some time to set up everything. I successfully retested changing the setting manually. I did not test the actual preview cause I have not figured out how to create a library that would load an image yet. Also added a screenshot.

jonas-ee · 2026-03-11T22:30:44Z

Code Review by Qodo

Concerning the Code Review by Qodo:

I could reuse the existing key but it should probably read "Enable ..." on the quick settings for consistency and I am not sure if I should change the existing translation because there are a lot of languages.
I didn't link the issue because it's private. I could open an issue but it might be easier to copy from the private one.

koppor · 2026-03-11T22:57:36Z

I didn't link the issue because it's private

The PR is linked in this case 😅

testlens-app · 2026-03-11T23:11:54Z

✅ All tests passed ✅

🏷️ Commit: 9055d1e
▶️ Tests: 10126 executed
⚪️ Checks: 62/62 completed

Learn more about TestLens at testlens.app.

jonas-ee · 2026-03-11T23:14:11Z

I didn't link the issue because it's private

The PR is linked in this case 😅

I see. Done.

koppor · 2026-03-13T10:47:10Z

Publicity posts:

@jonas-ee: I didn't find you on LinkedIn and Mastodon. Please comment so that I can link you (if you want ^^)

All in all: Thank you for taking part - and the follow-ups in this PR!

jonas-ee · 2026-03-14T12:01:49Z

Publicity posts:

https://www.linkedin.com/posts/oliverkopp_cover-images-download-new-toggle-button-activity-7438158651527163904-JsvT?utm_source=share&utm_medium=member_desktop&rcm=ACoAAACCUVQBYmlu_A9exTiDRiuXB95v-LNYD4c

https://mastodon.acm.org/@koppor/116215674597385356

@jonas-ee: I didn't find you on LinkedIn and Mastodon. Please comment so that I can link you (if you want ^^)

All in all: Thank you for taking part - and the follow-ups in this PR!

https://www.linkedin.com/in/jonas-haarz-036694153/
https://mastodon.social/@jonas_ee
Also added them to my github profile

) * Added new toggle button for cover images download in quick settings * CHANGELOG.md * PR added to CHANGELOG.md --------- Co-authored-by: jonas-ee <>

jonas-ee added 2 commits March 11, 2026 18:13

Added new toggle button for cover images download in quick settings

c194878

CHANGELOG.md

d79415b

github-actions Bot added the first contrib label Mar 11, 2026

Merge branch 'main' into quick-settings-cover-images-download-toggle

b41363e

jonas-ee changed the title ~~Added new toggle button for cover images download in quick settings~~ Cover images download: New toggle button in quick settings Mar 11, 2026

github-actions Bot added the status: no-bot-comments label Mar 11, 2026

This comment has been minimized.

Sign in to view

Merge branch 'main' into quick-settings-cover-images-download-toggle

3a3cc3c

This comment has been minimized.

Sign in to view

PR added to CHANGELOG.md

9055d1e

calixtus approved these changes Mar 12, 2026

View reviewed changes

calixtus added this pull request to the merge queue Mar 12, 2026

github-actions Bot added the status: to-be-merged PRs which are accepted and should go into the merge-queue. label Mar 12, 2026

Merged via the queue into JabRef:main with commit 2fa7182 Mar 12, 2026
61 of 62 checks passed

Uh oh!

Conversation

jonas-ee commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related issues and pull requests

PR Description

Steps to test

Checklist

Uh oh!

github-actions Bot commented Mar 11, 2026

Uh oh!

qodo-free-for-open-source-projects Bot commented Mar 11, 2026

Review Summary by Qodo

Walkthroughs

File Changes

Uh oh!

qodo-free-for-open-source-projects Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

koppor commented Mar 11, 2026

Uh oh!

koppor commented Mar 11, 2026

Uh oh!

This comment has been minimized.

Maran23 commented Mar 11, 2026

Uh oh!

jonas-ee commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonas-ee commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

koppor commented Mar 11, 2026

Uh oh!

testlens-app Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ All tests passed ✅

Uh oh!

jonas-ee commented Mar 11, 2026

Uh oh!

Uh oh!

koppor commented Mar 13, 2026

Uh oh!

jonas-ee commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jonas-ee commented Mar 11, 2026 •

edited

Loading

qodo-free-for-open-source-projects Bot commented Mar 11, 2026 •

edited

Loading

jonas-ee commented Mar 11, 2026 •

edited

Loading

jonas-ee commented Mar 11, 2026 •

edited

Loading

testlens-app Bot commented Mar 11, 2026 •

edited

Loading

jonas-ee commented Mar 14, 2026 •

edited

Loading