• Extract getCitationCount method into new CitationCountFetcher interface
• Make CitationFetcher extend the new CitationCountFetcher interface
• Remove empty lines from PdfMergeDialog for cleaner code formatting

Create CitationCountFetcher interface

• New interface file created to define citation count fetching contract
• Contains getCitationCount method that returns Optional<Integer>
• Includes comprehensive JavaDoc documentation

jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationCountFetcher.java

Make CitationFetcher extend CitationCountFetcher

• CitationFetcher now extends CitationCountFetcher interface
• getCitationCount method moved to parent interface
• Removed duplicate method documentation from this interface

jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationFetcher.java

Remove empty lines for cleaner formatting

• Removed unnecessary empty lines between method statements
• Improved code formatting consistency
• No functional changes to logic

jabgui/src/main/java/org/jabref/gui/externalfiles/PdfMergeDialog.java

Description

The newly introduced public interface CitationCountFetcher defines a public API without JSpecify
null-marking, making nullability contracts unclear and potentially triggering nullness/quality-gate
issues. This violates the project expectation to use JSpecify for nullability in new public APIs.

Code

jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationCountFetcher.java[R8-13]

+public interface CitationCountFetcher {
+    /// Get the paper details that includes citation count field for a given {@link BibEntry}.
+    ///
+    /// @param entry entry to search citation count field
+    /// @return returns a {@link Integer} for citation count field (may be empty)
+    Optional<Integer> getCitationCount(BibEntry entry) throws FetcherException;

Evidence

PR Compliance ID 14 requires using JSpecify for nullability in new public APIs.
CitationCountFetcher is newly added and lacks @NullMarked (or equivalent package-level null
marking), while the related CitationFetcher interface in the same package is explicitly annotated
with @NullMarked, indicating the expected convention.

AGENTS.md
jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationCountFetcher.java[8-13]
jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationFetcher.java[10-15]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
A new public interface (`CitationCountFetcher`) was introduced without JSpecify null-marking, which makes nullability expectations unclear and inconsistent with other interfaces in the same package.
## Issue Context
`CitationFetcher` in the same package is annotated with `@NullMarked`, suggesting the package expects JSpecify nullness defaults for public APIs.
## Fix Focus Areas
- jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationCountFetcher.java[1-14]
- jablib/src/main/java/org/jabref/logic/importer/fetcher/citation/CitationFetcher.java[10-15]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools