Skip to content

Add requirement to the banner#14664

Merged
koppor merged 2 commits into
mainfrom
add-banner-req
Dec 19, 2025
Merged

Add requirement to the banner#14664
koppor merged 2 commits into
mainfrom
add-banner-req

Conversation

@koppor

@koppor koppor commented Dec 19, 2025

Copy link
Copy Markdown
Member

Risen by #14500 (comment)

Just adds a requirement.

Follow-up create good first issue requesting

  1. Implementation
  2. Linking using OpenFastTrace

Steps to test

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor koppor requested a review from calixtus December 19, 2025 11:47
Comment thread docs/requirements/cli.md
The banner for the CLI ("JabKit") is only shown if the help is output.
Meaning: If there is no command given (falling back to help) or explicitly `--help` requested.

This increases the accessibility. Source: [Accessibility of Command Line Interfaces](https://dl.acm.org/doi/10.1145/3411764.3445544)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://dl.acm.org/doi/10.1145/3411764.3445544 Status: 403

@koppor koppor merged commit 3112935 into main Dec 19, 2025
54 of 55 checks passed
@koppor koppor deleted the add-banner-req branch December 19, 2025 15:16
Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
* Add requirement to the banner

* Workaround for linkspector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants