Skip to content

Change log levels from INFO to DEBUG for AI export#14649

Merged
koppor merged 3 commits into
JabRef:mainfrom
NiMv1:fix-log-levels-ai-export
Dec 18, 2025
Merged

Change log levels from INFO to DEBUG for AI export#14649
koppor merged 3 commits into
JabRef:mainfrom
NiMv1:fix-log-levels-ai-export

Conversation

@NiMv1

@NiMv1 NiMv1 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

Closes #14645

This PR changes AI export-related logging from info to debug to reduce log noise while keeping the information available in debug mode.

Steps to test

  1. Enable debug mode.
  2. Trigger an AI export.
  3. Verify that the related log output is emitted at debug level.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md (if applicable)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues.

Changes

  • Updated log level from info to debug in AI export-related code paths.
  • Added/updated CHANGELOG.md entry for the user-visible behavior change.

@github-actions github-actions Bot added good first issue An issue intended for project-newcomers. Varies in difficulty. status: changes-required Pull requests that are not yet complete labels Dec 18, 2025
@koppor koppor closed this Dec 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

This pull requests was closed without merging. You have been unassigned from the respective issue #14645.

@koppor koppor reopened this Dec 18, 2025
@koppor

koppor commented Dec 18, 2025

Copy link
Copy Markdown
Member

Implementation looks good. Was not aware of the "info" at dialog service. Let's see how the user feedback will be.

@koppor

koppor commented Dec 18, 2025

Copy link
Copy Markdown
Member

@NiMv1 Is it possible to add en entry to CHANGELOG.md? "Changed" and that notifications will be logged in debug mode only? Link https://docs.jabref.org/advanced/commandline#debug-mode-debug.

(I post this as this endeavour is for learning open source, not just implementing sth.)

@koppor

koppor commented Dec 18, 2025

Copy link
Copy Markdown
Member

@NiMv1 Seeing your PRs to other orgs, we need to check whether you are personally interested in scientific research. If yes, we should try to bring you deeper into JabRef. If not, we should give this opportunity to someone else.

@NiMv1 NiMv1 force-pushed the fix-log-levels-ai-export branch from ff0fe67 to ce71b92 Compare December 18, 2025 13:30
koppor
koppor previously approved these changes Dec 18, 2025
@koppor koppor enabled auto-merge December 18, 2025 13:40
@NiMv1

NiMv1 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

@koppor Thank you for the feedback and for approving the PR!

Regarding the CHANGELOG.md - I've added the entry as requested. The CI check 'CHANGELOG.md needs to be modified if indicated' seems to be from an older workflow run.

About scientific research - I appreciate you asking! While my primary focus is on backend development and distributed systems (as you can see from my other contributions), I do find bibliography management and academic tools interesting. I'm happy to contribute to JabRef when I can help with issues that match my skills.

I understand if you prefer to prioritize contributors who are more deeply involved in scientific research. Either way, I'm glad this PR could help improve the logging behavior.

Thank you for the learning opportunity!

auto-merge was automatically disabled December 18, 2025 16:42

Head branch was pushed to by a user without write access

@NiMv1

NiMv1 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

One CI check is failing due to repo permission limitations: 'Ensure that contributor is assigned'. The workflow tries to add @NiMv1 as an assignee to issue #14645 (which is labeled 'good first issue'), but GitHub API responds with 422 (invalid assignee) for external contributors. Could a maintainer please assign @NiMv1 to #14645 (or otherwise adjust the issue labels) so this check can pass?

@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 18, 2025
@NiMv1

NiMv1 commented Dec 18, 2025

Copy link
Copy Markdown
Contributor Author

Heads-up: the check 'Ensure that contributor is assigned' failed due to a GitHub API network timeout (dial tcp ...:443: i/o timeout) while PATCHing issue #14645. Looks like a transient CI/network flake. Could you please re-run the failed check/workflow? Thanks!

@koppor koppor merged commit 0d9b8fa into JabRef:main Dec 18, 2025
62 of 67 checks passed
@koppor

koppor commented Dec 18, 2025

Copy link
Copy Markdown
Member

@NiMv1 Thank you for your feedback. This is on the point. Highly appreciated. Maye, you could dive into #12261? Maybe, this is too large for now and you search for "quick wins", then just have look at good second issues.

@koppor

koppor commented Dec 18, 2025

Copy link
Copy Markdown
Member

@NiMv1 I think this issue could be good #10930 - You can check the comments on the closed PR #14252 if some refinement is needed.

Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue An issue intended for project-newcomers. Varies in difficulty.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change log levels for AI export

2 participants