Skip to content

Refactor 'ArXiv' to 'arXiv' in New Entry dialog#14648

Merged
koppor merged 7 commits into
JabRef:mainfrom
pKondaszewski:fix-issue-14643
Dec 19, 2025
Merged

Refactor 'ArXiv' to 'arXiv' in New Entry dialog#14648
koppor merged 7 commits into
JabRef:mainfrom
pKondaszewski:fix-issue-14643

Conversation

@pKondaszewski

Copy link
Copy Markdown
Contributor

Closes #14643

Steps to test

Mandatory checks

obraz

Observation during development:

I want to point out a possible issue with sorting order that is visible on the picture. Right now, sorting order of elements in dropbox is case sensitive (meaning that the order of elements is ABCabc, and it probably should be AaBbCc)

This is because of sorting method implemented here. I'm not sure if this a bug or not, just wanted to point it out because previously 'ArXiv' was at the top of the list, right now it's going to be closer to the bottom so this potentially could influence UI/UX experience just a little bit but idk.

The possible fix is smth like:

SortedSet<IdBasedFetcher> set = new TreeSet<>(Comparator.comparing(
        WebFetcher::getName,
        String.CASE_INSENSITIVE_ORDER
));

but technically, this is not the scope of the issue, so i'm keeping it as it is.

@github-actions

Copy link
Copy Markdown
Contributor

Hey @pKondaszewski! 👋

Thank you for contributing to JabRef!

We have automated checks in place, based on which you will soon get feedback if any of them are failing.

After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs.

Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow.

@github-actions github-actions Bot added first contrib good first issue An issue intended for project-newcomers. Varies in difficulty. labels Dec 18, 2025
@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 18, 2025
@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 18, 2025
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 18, 2025
new StudyCatalogItem("SemanticScholar", false),
new StudyCatalogItem("Springer", true),
new StudyCatalogItem("Unpaywall", false),
new StudyCatalogItem("arXiv", false),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep alphabetic ordering (ignore the casing)

@github-actions github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 18, 2025
@github-actions github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 18, 2025
@pKondaszewski pKondaszewski requested a review from koppor December 18, 2025 22:37
@koppor koppor added this pull request to the merge queue Dec 19, 2025
Merged via the queue into JabRef:main with commit 5a76cc8 Dec 19, 2025
49 checks passed
Siva-Sai22 pushed a commit to Siva-Sai22/jabref that referenced this pull request Dec 19, 2025
* Refactor 'ArXiv' to 'arXiv' in New Entry dialog

* ci: restore linear history after amend

* Refactor to case insensitive sorting approach

* Provide case insensitive sorting in getSearchBasedFetchers() method

* Fix remaining failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first contrib good first issue An issue intended for project-newcomers. Varies in difficulty.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"ArXiv" should cased "arXiv" in New Entry dialog

2 participants