Refactor 'ArXiv' to 'arXiv' in New Entry dialog#14648
Merged
Merged
Conversation
Contributor
|
Hey @pKondaszewski! 👋 Thank you for contributing to JabRef! We have automated checks in place, based on which you will soon get feedback if any of them are failing. After all automated checks pass, a maintainer will also review your contribution. Once that happens, you can go through their comments in the "Files changed" tab and act on them, or reply to the conversation if you have further inputs. Please re-check our AI Usage Policy to ensure that your pull request is in line with it. It also contains links to our contribution guide in case of any other doubts related to our contribution workflow. |
da65318 to
8cd8fef
Compare
koppor
requested changes
Dec 18, 2025
| new StudyCatalogItem("SemanticScholar", false), | ||
| new StudyCatalogItem("Springer", true), | ||
| new StudyCatalogItem("Unpaywall", false), | ||
| new StudyCatalogItem("arXiv", false), |
Member
There was a problem hiding this comment.
Keep alphabetic ordering (ignore the casing)
koppor
approved these changes
Dec 19, 2025
Siva-Sai22
pushed a commit
to Siva-Sai22/jabref
that referenced
this pull request
Dec 19, 2025
* Refactor 'ArXiv' to 'arXiv' in New Entry dialog * ci: restore linear history after amend * Refactor to case insensitive sorting approach * Provide case insensitive sorting in getSearchBasedFetchers() method * Fix remaining failing test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14643
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)Observation during development:
I want to point out a possible issue with sorting order that is visible on the picture. Right now, sorting order of elements in dropbox is case sensitive (meaning that the order of elements is ABCabc, and it probably should be AaBbCc)
This is because of sorting method implemented here. I'm not sure if this a bug or not, just wanted to point it out because previously 'ArXiv' was at the top of the list, right now it's going to be closer to the bottom so this potentially could influence UI/UX experience just a little bit but idk.
The possible fix is smth like:
but technically, this is not the scope of the issue, so i'm keeping it as it is.