Prevent bulk imports from adding entries to navigation history by shubhamk0205 · Pull Request #14550 · JabRef/jabref

shubhamk0205 · 2025-12-08T08:42:19Z

Prevent bulk import operations from polluting the navigation history. When multiple entries are imported at once, automatic selection changes are now suppressed from being recorded in the navigation history. This ensures that only user-driven navigation actions are tracked, keeping the Back/Forward buttons functional and predictable.

Steps to test

Open JabRef and create a new library
Import multiple entries at once (e.g., via File → Import → BibTeX, or drag-and-drop multiple .bib files)
After the import completes, verify that:
- The Back/Forward navigation buttons remain disabled (or show the correct state based on actual user navigation, not the bulk import)
- Manually selecting different entries adds them to navigation history as expected
- Using Back/Forward buttons only navigates through entries you actually visited, not entries from the bulk import

Expected behavior: Bulk imports should not enable Back/Forward navigation or add entries to navigation history. Only manual entry selections should affect navigation history.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
[/] I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
[/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

* Junie try 1 * Refine test * Fix casing

* Add JDK24 for gradle * Run JBang tests on JDK25 * Update build-support JBang scripts to require JDK25+ * Remove JDK24 installation * Weaken requirement for .jbang files * Add JDK24 * Relax JDK requirement (and sort deps alphabetically)

* Add fallback * Fix writing * Add link * Fix CHANGELOG.md --------- Co-authored-by: Christoph <siedlerkiller@gmail.com>

* Implement reset for MainTablePreferences Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * Added comments Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * Use List.of() instead of Collections.emptyList(). Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * rewriteRun + checkstyle set up Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * Revert "rewriteRun + checkstyle set up" This reverts commit 148ce13. --------- Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>

calixtus · 2025-12-10T18:19:39Z

+    /**
+     * Marks the start of a bulk import operation.
+     * During bulk import, selection changes will not be added to navigation history.
+     */
+    public void startBulkImport() {
+        bulkImportInProgress = true;
+    }
+
+    /**
+     * Marks the end of a bulk import operation.
+     * Normal navigation history tracking resumes after this call.
+     */
+    public void endBulkImport() {
+        bulkImportInProgress = false;
+    }
+


This is hacky as hell

…cted' (JabRef#14561) * change: Rename 'Search pre-configured' to 'Search pre-selected' and 'Web search fetchers' to 'Pre-selected fetchers' * fix: Update localization keys and unit tests * docs: Update CHANGELOG for UI label renames

* Refactor PagesChecker: Extract duplicate regex constants Fixes JabRef#14562 * fix comments dont align on indentation * Restore regex comments * Revert "Merge branch 'refactor-pages-clean' of https://github.com/Zeglow/jabref into clean-fix" This reverts commit 788979c, reversing changes made to a4a0236. * Revert "Restore regex comments" This reverts commit a4a0236. * restore MainTablePreferences.java, JabRefGuiPreferences.java and PagesChecker.java * fix comment formatting issue

* Implement reset for MainTablePreferences Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * Added comments Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * Use List.of() instead of Collections.emptyList(). Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * rewriteRun + checkstyle set up Signed-off-by: Annabel Wang <annabelwyn11@gmail.com> * Revert "rewriteRun + checkstyle set up" This reverts commit 148ce13. --------- Signed-off-by: Annabel Wang <annabelwyn11@gmail.com>

…cted' (JabRef#14561) * change: Rename 'Search pre-configured' to 'Search pre-selected' and 'Web search fetchers' to 'Pre-selected fetchers' * fix: Update localization keys and unit tests * docs: Update CHANGELOG for UI label renames

* Refactor PagesChecker: Extract duplicate regex constants Fixes JabRef#14562 * fix comments dont align on indentation * Restore regex comments * Revert "Merge branch 'refactor-pages-clean' of https://github.com/Zeglow/jabref into clean-fix" This reverts commit 788979c, reversing changes made to a4a0236. * Revert "Restore regex comments" This reverts commit a4a0236. * restore MainTablePreferences.java, JabRefGuiPreferences.java and PagesChecker.java * fix comment formatting issue

* Parameterize tests (issue JabRef#676) * Address code review feedback * Fix code style * Remove spaces before delimiter in CSV test data * Restore trailing comma in test cases * Add missing test case * Adress review comments --------- Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

* New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Portuguese, Brazilian)

…Ref#14534) * Add 15 non-standard BibLaTeX entry types with .withType() method * updated ChangeLog.md * fixed formatting issue * fixed Formatting * fixed Checkstyle's DeclarationOrder * fix checkstyle errors * fixed Key Collision error * New Crowdin updates (JabRef#14535) * New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Danish) * New translations jabref_en.properties (German) * New translations jabref_en.properties (Greek) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Japanese) * New translations jabref_en.properties (Korean) * New translations jabref_en.properties (Dutch) * New translations jabref_en.properties (Norwegian) * New translations jabref_en.properties (Polish) * New translations jabref_en.properties (Portuguese) * New translations jabref_en.properties (Russian) * New translations jabref_en.properties (Swedish) * New translations jabref_en.properties (Turkish) * New translations jabref_en.properties (Chinese Simplified) * New translations jabref_en.properties (Vietnamese) * New translations jabref_en.properties (Portuguese, Brazilian) * New translations jabref_en.properties (Indonesian) * New translations jabref_en.properties (Tagalog) * Revise JavaDoc links in README.md (JabRef#14533) * applied given changes * fixed formatting * fixed formatting * Update jabgui/src/main/java/org/jabref/gui/menus/ChangeEntryTypeMenu.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> * fixed alphabatical ordering * Fix link * Proxy Preference reset (JabRef#14554) * Fix typos (JabRef#14552) * Add LlmPlainCitationParserTest (JabRef#14553) * Junie try 1 * Refine test * Fix casing * updated ChangeLog.md * moved the non-standard types to their own own enum class and updated the connected files * eevert "Proxy Preference reset (JabRef#14554)" This reverts commit 430b6b9. Clean PR * Fix CHANGELOG.md --------- Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Oliver Kopp <kopp.dev@gmail.com> Co-authored-by: Lalit Kumar Verma <lalit2506verma@gmail.com>

…/jabref into fix-for-issue-13878

shubhamk0205 · 2025-12-11T23:16:35Z

Closing this PR and replacing it with #14575 which has a cleaner commit history. The changes are identical.

calixtus · 2025-12-11T23:26:24Z

Dont close prs and reopen. GitHub will automatically update your pr if you push to. In rare cases, if you totally mess up your commit history, you may force push.

Our comments will be lost.

shubhamk0205 · 2025-12-11T23:33:06Z

Dont close prs and reopen. GitHub will automatically update your pr if you push to. In rare cases, if you totally mess up your commit history, you may force push.

Our comments will be lost.

i will surely keep this in mind @calixtus , i thought i had no option because i thought that the CI reject changes with force push as i once tried earlier

calixtus · 2025-12-12T07:37:10Z

Ci will complain, yes, but not reject. As I said, in rare cases only. But the tradeoff is less heavy as creating a new pr with a new branch in my eyes

shubhamk0205 · 2025-12-12T08:45:49Z

Ci will complain, yes, but not reject. As I said, in rare cases only. But the tradeoff is less heavy as creating a new pr with a new branch in my eyes

from next time i will keep this in mind , Thanks for guiding : )

Prevent bulk imports from adding entries to navigation history

99c3cf7

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

Updated ImportHandlerTest

6a390a5

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

shubhamk0205 added 2 commits December 8, 2025 15:25

fixed CI errors

5787d36

fixed CI errors

408a46b

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

fixed CI errors

dd7811c

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

fixed CI errors

dc62aa1

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

shubhamk0205 added 2 commits December 8, 2025 18:18

fixed CI errors

0119f15

fixed CI errors

addcd66

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 8, 2025

shubhamk0205 and others added 6 commits December 8, 2025 18:40

fixed CI errors

8d8ab3d

Merge branch 'main' into fix-for-issue-13878

5772178

Fix link

789b294

Proxy Preference reset (JabRef#14554)

4b8ed07

Fix typos (JabRef#14552)

37e5caf

Add LlmPlainCitationParserTest (JabRef#14553)

d24aa92

* Junie try 1 * Refine test * Fix casing

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 8, 2025

koppor and others added 6 commits December 9, 2025 09:23

Create README.md for JabKit project

dd95e05

Add JDK24 for gradle (JabRef#14560)

d101b2e

* Add JDK24 for gradle * Run JBang tests on JDK25 * Update build-support JBang scripts to require JDK25+ * Remove JDK24 installation * Weaken requirement for .jbang files * Add JDK24 * Relax JDK requirement (and sort deps alphabetically)

Add fallback (JabRef#14520)

d5c3200

* Add fallback * Fix writing * Add link * Fix CHANGELOG.md --------- Co-authored-by: Christoph <siedlerkiller@gmail.com>

Rerun only on main repo

8286ff2

Add documentation link for jabsrv

8de881f

calixtus reviewed Dec 10, 2025

View reviewed changes

mayank1008-tech and others added 2 commits December 11, 2025 08:19

koppor and others added 9 commits December 12, 2025 03:26

Rerun only on main repo

db6a8fa

Add documentation link for jabsrv

8cae2f3

New Crowdin updates (JabRef#14570)

dc89fc6

* New translations jabref_en.properties (French) * New translations jabref_en.properties (Spanish) * New translations jabref_en.properties (Italian) * New translations jabref_en.properties (Portuguese, Brazilian)

Fix bulk imports adding entries to navigation history

cde171f

shubhamk0205 requested a review from calixtus December 11, 2025 22:06

shubhamk0205 added 12 commits December 12, 2025 04:05

Prevent bulk imports from adding entries to navigation history

73119df

Updated ImportHandlerTest

7857fc2

fixed CI errors

c80dd53

fixed CI errors

9dedc3d

fixed CI errors

131221c

fixed CI errors

8d367a2

fixed CI errors

60d89e4

fixed CI errors

c305e47

fixed CI errors

e2bfbba

Fix bulk imports adding entries to navigation history

1e1f734

Merge branch 'fix-for-issue-13878' of https://github.com/shubhamk0205…

daa6d59

…/jabref into fix-for-issue-13878

Revert accidental merge daa6d59 that pulled main into branch

26461d4

shubhamk0205 closed this Dec 11, 2025

shubhamk0205 deleted the fix-for-issue-13878 branch December 11, 2025 23:22

koppor mentioned this pull request Dec 12, 2025

Fix bulk imports adding entries to navigation history #14575

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Prevent bulk imports from adding entries to navigation history#14550

Prevent bulk imports from adding entries to navigation history#14550
shubhamk0205 wants to merge 53 commits into
JabRef:mainfrom
shubhamk0205:fix-for-issue-13878

shubhamk0205 commented Dec 8, 2025 •

edited

Loading

Uh oh!

calixtus Dec 10, 2025

Uh oh!

shubhamk0205 commented Dec 11, 2025

Uh oh!

calixtus commented Dec 11, 2025

Uh oh!

shubhamk0205 commented Dec 11, 2025

Uh oh!

calixtus commented Dec 12, 2025

Uh oh!

shubhamk0205 commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

shubhamk0205 commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Steps to test

Mandatory checks

Uh oh!

calixtus Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

shubhamk0205 commented Dec 11, 2025

Uh oh!

calixtus commented Dec 11, 2025

Uh oh!

shubhamk0205 commented Dec 11, 2025

Uh oh!

calixtus commented Dec 12, 2025

Uh oh!

shubhamk0205 commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

shubhamk0205 commented Dec 8, 2025 •

edited

Loading