Move authorsAlpha and authorsAlphaLNI tests to BracketedPatternTest#14517
Merged
Conversation
Member
|
I am out of context, but I hope the issue was right. |
koppor
approved these changes
Dec 5, 2025
Member
Which PR is this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13930
Moves concrete pattern tests for
[authorsAlpha]and[authorsAlphaLNI]fromCitationKeyGeneratorTesttoBracketedPatternTest, following the same pattern as thelastAuthormigration in PR #676. This addresses the comment inCitationKeyGeneratorTestthat concrete patterns should be tested atBracketedPatternTestrather than in the citation key generator test class. The tests are now properly located where they test the pattern logic directly usingAuthorListobjects, rather than testing the full citation key generation flow withBibEntryobjects.Steps to test
Run the test suite for
BracketedPatternTest:h./gradlew :jablib:test --tests "org.jabref.logic.citationkeypattern.BracketedPatternTest"
2. Verify that the
authorsAlpha()andauthorsAlphaLNI()test methods pass with all test cases, including the newly migrated ones:Verify that
CitationKeyGeneratorTeststill compiles and runs successfully:./gradlew :jablib:test --tests "org.jabref.logic.citationkeypattern.CitationKeyGeneratorTest"
4. Confirm that no references to the removed test methods or constants exist in
CitationKeyGeneratorTest.Mandatory checks
I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
[/] I added screenshots in the PR description (if change is visible to the user)
[/] I described the change in
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)[/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.