Skip to content

Fix review process message in PR template#14351

Merged
koppor merged 2 commits into
JabRef:mainfrom
palukku:refine-pr-message
Nov 18, 2025
Merged

Fix review process message in PR template#14351
koppor merged 2 commits into
JabRef:mainfrom
palukku:refine-pr-message

Conversation

@palukku

@palukku palukku commented Nov 18, 2025

Copy link
Copy Markdown
Member

Since Trag Bot doesn't exist anymore, we should remove that part of the message.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor koppor merged commit 76f956a into JabRef:main Nov 18, 2025
42 of 46 checks passed
@palukku palukku deleted the refine-pr-message branch November 18, 2025 15:41
TragBot is still learning, and may not always be accurate.
In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.
Later on in the review process, one of our maintainers will also go through your contribution.
In the "Files changed" tab, you can go through his comments and just click on "Resolve conversation" if you resolved the comment, or answer him on the conversation if you have further input regarding his comment.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Their, them, their
I also don't think resolution by the contributor is a good idea, it's led to some very frustrating moments in the past

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll file a follow-up

merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@subhramit subhramit mentioned this pull request Nov 20, 2025
1 task
@koppor koppor mentioned this pull request Dec 23, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants