Add final modifier and private constructor for MathMLParser#14345
Merged
Conversation
koppor
approved these changes
Nov 18, 2025
koppor
previously requested changes
Nov 18, 2025
koppor
left a comment
Member
There was a problem hiding this comment.
Suggestion from https://github.com/JabRef/jabref/pull/14344/files#r2536940033 should be applied
Siedlerchr
approved these changes
Nov 19, 2025
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
…4345) * Add final modifier and private constructor * Update exception message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14346
Added
finalmodifier and private constructor toMathMLParserutility class to prevent instantiation and subclassing, following Java best practices for utility classes containing only static methods.@espertusnu - This addresses the utility class refactoring discussed on Gitter.
Steps to test
./gradlew build./gradlew testMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)