Add final modifier and private constructor for StaxParser#14343
Merged
Conversation
Member
|
Oh wait, you created a separate PR for each class? Maybe, this is a requirement from your class? I, just, believe that doing everything in 1 PR would be faster to process and review |
Member
|
Sorry, Nakul. I have read the discussion on Gitter right now, and now I understood why there are separate PRs. Okay, everything's fine from your side! But I believe it's better to change the error message to something more specific |
Contributor
Author
|
Hi @InAnYan, No worries!! I've updated the exception message to "Cannot instantiate a utility class" as you suggested. Thank you for the feedback! All 6 PRs now have the updated, more specific error message. |
Siedlerchr
approved these changes
Nov 19, 2025
Closed
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
* Add final modifier and private constructor * Update exception message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14346
Added
finalmodifier and private constructor toStaxParserutility class to prevent instantiation and subclassing, following Java best practices for utility classes containing only static methods.@espertusnu - This addresses the utility class refactoring discussed on Gitter.
Steps to test
./gradlew build./gradlew testMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)