Initial framework for jablib-examples#14233
Merged
Merged
Conversation
- BibliographyFromPdfImporter is also an PdfImporter - importDatabase returns ParserResult (for consistency)
(and fix BibligraphyFromPdfImporter method use)
InAnYan
previously approved these changes
Nov 6, 2025
jabref-machine
approved these changes
Nov 6, 2025
subhramit
reviewed
Nov 6, 2025
| return CitationSplitter.splitCitations(text) | ||
| .map(Unchecked.function(this::parsePlainCitation)) | ||
| .flatMap(Optional::stream) | ||
| .collect(Collectors.toList()); |
Member
There was a problem hiding this comment.
Suggested change
| .collect(Collectors.toList()); | |
| .toList(); |
This was referenced Nov 6, 2025
Merged
merlinymy
pushed a commit
to merlinymy/jabref
that referenced
this pull request
Nov 19, 2025
* Initial framework for jablib-examples * Rename "serializeAll" to "writeAll" * Add some `@NonNull` annotations * Even more consistent * More renamings * Add convenience constructor * Add some nullable annotations * Add cross-links * Fix typo * Fix class name * Have BibliographyFromPdfImporter implementing PlainCitationParser * Add "IEEE" as another rule option * Fix method name (and visibility) * Compilefix * Fix casing in BibTeX * Enable LLM to be used to parse references * Refine code - BibliographyFromPdfImporter is also an PdfImporter - importDatabase returns ParserResult (for consistency) * Move pdf related importers to pdf sub package * Initial PdfImporterWithPlainCitationParser * WIP: ieee_pdf_references_to_bibtex * Add link to CHANGELOG.md * Refine PlainCitationParser interface * Move methods to PdfUtils * Make LlmPlainCitationParser a real importer (and fix BibligraphyFromPdfImporter method use) * Add missing class * Wire all availble importers * Rename BibliographyFromPdfImporter to RuleBasedBibliographyPdfImporter * Introdue intermediate class BibliographyFromPdfImporter * Fix PdfGrobitImporter (to really extract the references) * Add comment * Fix JavaFX graphics dependency in ProgressCounter * Remove routing method * Remove obsolete test file * Add development hint to README.md * First version of to BibTeX conversion * Adapt test to new behavior * Apply format * Fix NullAway warning * Fix Moderinzer * Refine checkstyle supressions * Fix typo * Use release version of action-checkstyle * Move complete file ignores to checkstyle.xml * Also run if jbang scripts themselves have changed * Add link * Update checkstyle version in checkstyle-idea.xml * Remove obsolete comment * Apply suggestions from code review Co-authored-by: Ruslan <ruslanpopov1512@gmail.com> * Fix checkstyle * Increase IntelliJ version * Switch to other formatter * Fix checkstyle * Fix reference * Apply renaming also in script * Fix jbang build command (double .java) * Workaround for formatter issue * Switch back to other formatter (better output) * Remove one more ".java" * Try to list all files * Rename "simple" to "general" * Debug: output modified files * Add missing } * Try other way for debugging * Ohter debug * Fix debug * Fix copy and paste error * Output script * Remove obsolete ".java" * Remove debug * Remove "build" * Fix source adaption * Refine tests * Better grouping --------- Co-authored-by: Christoph <siedlerkiller@gmail.com> Co-authored-by: Ruslan <ruslanpopov1512@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the modularization we got "jablib". Now, its time to offer it as "useful" library.
I tried to write some scripts in JBang, but the API of JabRef was less than OKish, so I refactored.
Aim for this PR:
DOI to BibTeX--> follow-up PRAdditional Changes
IEEE as explicit rule-based parser available
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)