Skip to content

fix(merge-dialog): fix 'treat duplicates the same way' checkbox#14224

Merged
Siedlerchr merged 6 commits into
JabRef:mainfrom
InAnYan:fix/treat-duplicates-same
Nov 8, 2025
Merged

fix(merge-dialog): fix 'treat duplicates the same way' checkbox#14224
Siedlerchr merged 6 commits into
JabRef:mainfrom
InAnYan:fix/treat-duplicates-same

Conversation

@InAnYan

@InAnYan InAnYan commented Nov 2, 2025

Copy link
Copy Markdown
Member

Closes https://github.com/JabRef/jabref-issue-melting-pot/issues/720

Previously, if your library had a lot of duplicate entries, and you want to quickly merge them, you couldn't do this easily. There is a checkbox "Treat duplicates the same way", but it never worked. This PR solves this program, and it works now like this:

Scenario 1:

  1. Running duplicate check
  2. Checkbox not checked
  3. For each duplicate a merge dialog opens

Scenario 2:

  1. Running duplicate check
  2. Ticking checkbox for treating duplicates the same way
  3. Clicking "Keep merged"
  4. Jabref finishes everything else automatically

Scenario 3 (checkbox was ticked previously):

  1. Running duplicate check
  2. The check box is already ticked
  3. Clicking "Keep merged"
  4. Jabref finishes everything else automatically

I put Scenario 3 here, because even if the checkbox is ticked, there is a way to untick it.

Steps to test

  1. Have a library with a lot of duplicates (for example, run SLR)
  2. Run duplicate check
  3. Tick "Treat duplicates the same way"
  4. Click "Keep merged"

After that JabRef merges duplicates automatically.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

Comment thread CHANGELOG.md Outdated
Comment thread jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java Outdated
Comment thread CHANGELOG.md Outdated
Comment thread jabgui/src/main/java/org/jabref/gui/duplicationFinder/DuplicateSearch.java Outdated
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
Comment thread CHANGELOG.md Outdated
@InAnYan InAnYan added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 6, 2025
@Siedlerchr Siedlerchr added this pull request to the merge queue Nov 8, 2025
Merged via the queue into JabRef:main with commit e0fc3e4 Nov 8, 2025
47 of 56 checks passed
@Siedlerchr Siedlerchr deleted the fix/treat-duplicates-same branch November 8, 2025 17:20
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
…ef#14224)

* fix(merge-dialog): fix 'treat duplicates the same way' checkbox

* docs(changelog): add (draft) changelog entry

* refactor(duplicates): remove comment

* Apply suggestions from code review

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>

* Update CHANGELOG.md

---------

Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants