Skip to content

Collects sorting items under Sort submenu in groups menu#14148

Merged
Siedlerchr merged 4 commits into
JabRef:mainfrom
ennymojje:fix-for-issue-14017
Oct 23, 2025
Merged

Collects sorting items under Sort submenu in groups menu#14148
Siedlerchr merged 4 commits into
JabRef:mainfrom
ennymojje:fix-for-issue-14017

Conversation

@ennymojje

@ennymojje ennymojje commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Closes #14017

This PR moves all "Sort by..." menu items in the Groups menu into a dedicated "Sort" sub-menu.

Steps to test

  1. Open Groups panel.
  2. Right click on one of the groups in the panel.
  3. Verify that the "Sort by..." options are now inside a submenu named "Sort".
  4. Check that the groups are still sorted correctly when using different sorting options.

Before:
before

After:
after

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • I checked the user documentation: it is still accurate and up to date.

@github-actions

github-actions Bot commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

Hey @ennymojje!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 23, 2025
calixtus
calixtus reviewed Oct 23, 2025
View reviewed changes
Comment thread jabgui/src/main/java/org/jabref/gui/groups/GroupTreeView.java Outdated
@calixtus calixtus changed the title Collects sorting items under Sort submenu in groups menu (JabRef#14017) Collects sorting items under Sort submenu in groups menu Oct 23, 2025
@calixtus

calixtus commented Oct 23, 2025

Copy link
Copy Markdown
Member

Looks good to me. Second review required before merging. Thanks for your contribution.

@calixtus calixtus mentioned this pull request Oct 23, 2025
Closed
3 tasks
@Siedlerchr Siedlerchr added this pull request to the merge queue Oct 23, 2025
Merged via the queue into JabRef:main with commit afced0b Oct 23, 2025
57 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 23, 2025
Closed
merlinymy pushed a commit to merlinymy/jabref that referenced this pull request Nov 19, 2025
@ennymojje @merlinymy
Collects sorting items under Sort submenu in groups menu (JabRef#14148)
1c74f77 
* Collects sorting items under Sort submenu in groups menu (JabRef#14017)

* Addchangelog entry for sort submenu in groups panel (JabRef#14017)

* add sort-label for groups submenu (JabRef#14017)

* inlined changes for sortgroup (JabRef#14017)

---------

Co-authored-by: Jenny Hanås <jenha090@student.liu.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus approved these changes

Assignees

No one assigned

Labels

first contrib status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Put sort items in "group" menu into sub-menu

3 participants

@ennymojje @calixtus @Siedlerchr